refactor(orchestrator): make stack detachment explicit - #488
Open
LukeMathWalker wants to merge 1 commit into
Open
Conversation
LukeMathWalker
force-pushed
the
refactor/orchestrator-explicit-detach
branch
from
August 10, 2026 06:42
197da9b to
d572283
Compare
LukeMathWalker
force-pushed
the
refactor/orchestrator-explicit-detach
branch
2 times, most recently
from
August 10, 2026 07:01
288324f to
f123fc8
Compare
LukeMathWalker
force-pushed
the
refactor/orchestrator-explicit-detach
branch
from
August 10, 2026 08:43
f123fc8 to
ea776f1
Compare
LukeMathWalker
force-pushed
the
refactor/orchestrator-explicit-detach
branch
from
August 10, 2026 14:59
ea776f1 to
bb887c0
Compare
LukeMathWalker
marked this pull request as ready for review
August 10, 2026 15:16
github-merge-queue
Bot
removed this pull request from the merge queue because the pull requests in the stack were not ordered correctly in the queue
Aug 10, 2026
LukeMathWalker
force-pushed
the
refactor/orchestrator-explicit-detach
branch
from
August 10, 2026 15:21
bb887c0 to
94f8d48
Compare
LukeMathWalker
force-pushed
the
refactor/orchestrator-explicit-detach
branch
from
August 10, 2026 16:33
94f8d48 to
acadc48
Compare
LukeMathWalker
force-pushed
the
refactor/orchestrator-explicit-detach
branch
from
August 10, 2026 16:57
acadc48 to
bc21d3f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Dropping
RunningStackimplicitly left processes running, but collector startup failure could instead terminate them. That made destructor behavior depend on an incidental thread-creation result and allowed accidental owner loss to leave an unsupervised stack.What Changed
RunningStack::detachownership transferRisks / Notes
This intentionally changes internal lifecycle behavior: callers that want processes to outlive
RunningStackmust calldetach. Graceful teardown remains available throughshutdown. This is the sixth PR in the lifecycle-ownership stack and targets #487.AI Assistance
Implementation assisted by OpenAI GPT-5.4.