fix(orchestrator): bound destructor collection handoff - #489
Open
LukeMathWalker wants to merge 3 commits into
Open
fix(orchestrator): bound destructor collection handoff#489LukeMathWalker wants to merge 3 commits into
LukeMathWalker wants to merge 3 commits into
Conversation
LukeMathWalker
force-pushed
the
fix/orchestrator-bounded-drop-collector
branch
from
August 10, 2026 06:42
733346d to
9e265ce
Compare
LukeMathWalker
force-pushed
the
fix/orchestrator-bounded-drop-collector
branch
2 times, most recently
from
August 10, 2026 07:01
21084bb to
fec1f45
Compare
LukeMathWalker
force-pushed
the
fix/orchestrator-bounded-drop-collector
branch
from
August 10, 2026 08:43
fec1f45 to
e1259ab
Compare
LukeMathWalker
force-pushed
the
fix/orchestrator-bounded-drop-collector
branch
from
August 10, 2026 14:59
e1259ab to
352aaf1
Compare
LukeMathWalker
marked this pull request as ready for review
August 10, 2026 15:16
github-merge-queue
Bot
removed this pull request from the merge queue because the pull requests in the stack were not ordered correctly in the queue
Aug 10, 2026
LukeMathWalker
force-pushed
the
fix/orchestrator-bounded-drop-collector
branch
from
August 10, 2026 15:21
352aaf1 to
55b03e8
Compare
LukeMathWalker
force-pushed
the
fix/orchestrator-bounded-drop-collector
branch
from
August 10, 2026 16:33
55b03e8 to
1e86995
Compare
LukeMathWalker
force-pushed
the
fix/orchestrator-bounded-drop-collector
branch
from
August 10, 2026 16:57
1e86995 to
4a3280c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Destructor fallbacks could create a reaper thread and then call an unbounded
Child::waitif thread creation failed. Under resource exhaustion, dropping an orchestration guard could therefore wedge the process indefinitely.What Changed
Risks / Notes
Explicit rollback may still wait while returning a cleanup error; destructor paths only hard-signal and enqueue. If the pre-initialized worker disconnects unexpectedly,
Dropdeliberately retains the rejected capabilities until process exit rather than blocking or releasing Windows Job authority. Raw fork-without-exec reuse of the library is outside its supported contract. This PR fixes the high-severity review finding on the lifecycle-ownership stack and targets #488.AI Assistance
Implementation assisted by OpenAI GPT-5.4.