refactor(orchestrator): report startup rollback failures - #485
Merged
LukeMathWalker merged 1 commit intoAug 10, 2026
Merged
Conversation
LukeMathWalker
force-pushed
the
refactor/orchestrator-explicit-startup-rollback
branch
from
August 10, 2026 06:42
46badc1 to
86970bb
Compare
LukeMathWalker
force-pushed
the
refactor/orchestrator-explicit-startup-rollback
branch
2 times, most recently
from
August 10, 2026 07:01
d675316 to
abbe609
Compare
LukeMathWalker
force-pushed
the
refactor/orchestrator-explicit-startup-rollback
branch
from
August 10, 2026 08:43
abbe609 to
a5134bb
Compare
LukeMathWalker
force-pushed
the
refactor/orchestrator-explicit-startup-rollback
branch
from
August 10, 2026 14:59
a5134bb to
ea36666
Compare
LukeMathWalker
marked this pull request as ready for review
August 10, 2026 15:15
github-merge-queue
Bot
removed this pull request from the merge queue because the pull requests in the stack were not ordered correctly in the queue
Aug 10, 2026
LukeMathWalker
force-pushed
the
refactor/orchestrator-explicit-startup-rollback
branch
from
August 10, 2026 15:21
ea36666 to
f749f8b
Compare
Base automatically changed from
refactor/orchestrator-detached-launch-guard
to
main
August 10, 2026 16:33
LukeMathWalker
force-pushed
the
refactor/orchestrator-explicit-startup-rollback
branch
from
August 10, 2026 16:33
f749f8b to
ed9e8a1
Compare
LukeMathWalker
deleted the
refactor/orchestrator-explicit-startup-rollback
branch
August 10, 2026 16:57
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Normal startup failures relied on
StartupGuard::drop, which cannot return cleanup errors and may hide blocking rollback work in destructor control flow. Complete rollback should be an explicit lifecycle transition, whileDropshould remain only a fail-closed backstop.What Changed
Dropfor hard termination and collection handoffRisks / Notes
This changes the error structure when both startup and rollback fail: callers now receive
StartError::Rollbackinstead of only the initiating error. This is the third PR in the lifecycle-ownership stack and targets #484.AI Assistance
Implementation assisted by OpenAI GPT-5.4.