Skip to content

refactor(orchestrator): complete generation cleanup attempts - #486

Open
LukeMathWalker wants to merge 1 commit into
mainfrom
refactor/orchestrator-exhaustive-state-cleanup
Open

refactor(orchestrator): complete generation cleanup attempts#486
LukeMathWalker wants to merge 1 commit into
mainfrom
refactor/orchestrator-exhaustive-state-cleanup

Conversation

@LukeMathWalker

Copy link
Copy Markdown
Contributor

Why

Generation cleanup stopped at the first filesystem error, leaving later removable artifacts untouched. Cleanup should make a complete attempt while preserving the generation lock whenever any artifact remains uncertain.

What Changed

  • attempt every derivable generation artifact after the lease check
  • retain the first cleanup error while continuing later removals
  • preserve an unreadable supervisor PID file for retry evidence
  • remove stack.lock only after every other cleanup succeeds
  • cover partial cleanup and retry behavior with an integration test

Risks / Notes

Process absence and generation fencing remain prerequisites. This PR changes only cleanup completeness and keeps the generation lock as the final commit marker. It is the fourth PR in the lifecycle-ownership stack and targets #485.

AI Assistance

Implementation assisted by OpenAI GPT-5.4.

@LukeMathWalker
LukeMathWalker force-pushed the refactor/orchestrator-exhaustive-state-cleanup branch from 23e1c32 to 16801bc Compare August 10, 2026 06:42
@LukeMathWalker
LukeMathWalker force-pushed the refactor/orchestrator-exhaustive-state-cleanup branch from 16801bc to d00f178 Compare August 10, 2026 06:55
@LukeMathWalker
LukeMathWalker force-pushed the refactor/orchestrator-exhaustive-state-cleanup branch from d00f178 to 5a13b1e Compare August 10, 2026 07:01
@LukeMathWalker
LukeMathWalker force-pushed the refactor/orchestrator-exhaustive-state-cleanup branch from 5a13b1e to 952d89c Compare August 10, 2026 08:43
@LukeMathWalker
LukeMathWalker force-pushed the refactor/orchestrator-exhaustive-state-cleanup branch from 952d89c to e14095d Compare August 10, 2026 14:59
@LukeMathWalker
LukeMathWalker marked this pull request as ready for review August 10, 2026 15:15
@LukeMathWalker
LukeMathWalker added this pull request to the merge queue Aug 10, 2026
@github-merge-queue
github-merge-queue Bot removed this pull request from the merge queue because the pull requests in the stack were not ordered correctly in the queue Aug 10, 2026
@LukeMathWalker
LukeMathWalker force-pushed the refactor/orchestrator-exhaustive-state-cleanup branch from e14095d to db0189f Compare August 10, 2026 15:21
@LukeMathWalker
LukeMathWalker force-pushed the refactor/orchestrator-exhaustive-state-cleanup branch from db0189f to 6bb4628 Compare August 10, 2026 16:33
Base automatically changed from refactor/orchestrator-explicit-startup-rollback to main August 10, 2026 16:57
@LukeMathWalker
LukeMathWalker force-pushed the refactor/orchestrator-exhaustive-state-cleanup branch from 6bb4628 to 7a22d3b Compare August 10, 2026 16:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant