refactor(v4): split MIR construction from representation - #92
Draft
OttoApocalypse69 wants to merge 2 commits into
Draft
refactor(v4): split MIR construction from representation#92OttoApocalypse69 wants to merge 2 commits into
OttoApocalypse69 wants to merge 2 commits into
Conversation
- Move HIR and TY lowering into freak_mir_build - Keep Built-MIR storage and snapshot v5 in freak_mir - Guard crate order and update conformance audit routing
- Move representation-only local lookups into freak_mir - Keep return-loan interpretation in Meiya over canonical TY queries - Guard downstream calls and transitional syntax dependencies
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Comment |
This was referenced Aug 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
freak_mirfor persistent Built-MIR representation, validation, and snapshot v5, andfreak_mir_buildfor HIR+TY-to-MIR construction policy and request-scoped scratch.v4_mir_lower_ty, allocation order, query/driver/editor/snapshot behavior, and byte-identical snapshot/restore task bodies.freak_borrowck; borrowck and LLVM no longer call builder-owned tasks.Why this boundary
freak_mirowns the stable Built-MIR data model.freak_mir_buildowns source-facing lowering policy. This is the mechanical predecessor for No-Syntax-Past-HIR slices andfreak_mir_transform; it deliberately does not redesign MIR or version snapshot v5.Validation
Exact head:
5928d4ad685fe47053b8cb10f9c717f31ee3599bBase:
fix/v4-post-merge-contract-hardening@d26e2e79be8883eabdaf26ad71af6d59b0e7236b(#91)check_v4.py --fast: all 247 fixtures, 3,618 statements, 39.5 MB peak, exit 0.Pending
Current-head CI and automated review on this stacked draft PR.
Conservative boundaries
freak_mir_buildare documented and exactly pinned for later shrinkage.