Lower V4 local annotations from semantic HIR facts - #94
Draft
OttoApocalypse69 wants to merge 4 commits into
Draft
Conversation
- Store task-local declaration annotation types and spans in HIR/TY - Lower annotated pilot declarations without reconstructing type text in MIR - Add fixed, tuple, list, snapshot, diagnostic, and Meiya coverage
- Validate versioned HIR annotation snapshot ownership and slots - Guard the exact remaining MIR build type-text consumers - Document and test atomic malformed-snapshot rejection
Reject malformed ownership and slot variants before restore. Guard HIR and TY accessors against syntax reconstruction. Keep negative lowering checks live after snapshot truncation.
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
freak_mir_buildconsume those semantic facts for local declarationsOwnership boundary
HIR owns declaration syntax facts once; TY owns canonicalization and diagnostics;
freak_mir_buildconsumes TY. MIR still uses body tokens for CFG, patterns, places, and expression boundaries. This is one vertical boundary slice, not the entire No-Syntax-Past-HIR cleanup.Validation
47c77abaeebfdf28e4e10c41d5f4665398fce838: APPROVE, no P0-P3check_v4.py --fast: all 248 fixtures pass, 3,662 flattened statements, 42.8 MB peak retained,CHECK_EXIT=0python -u -m py_compile src/compiler/v4/check_v4.py: passpython -u -m freakc audit-conformance: passStack and conservative boundary
This draft is stacked on
refactor/v4-mir-build-split/ PR #92. The next recommended semantic family is ordinary task declared return annotations; call-site and pattern syntax remain later slices. GitHub CI and automated review are pending.