Lifecycle step 7 (5/5): tested end to end; docs as built - #61
Merged
Merged
Conversation
The test on 2026-09-30 (a throwaway mentor row, P0074, and account) passed: Remove from groups, in production for the first time, took them out of grp-mentors, grp-all-team and grp-orders; Suspend and Restore worked; the groups run re-added them when Active again. Suspend was refused with only Users → Update → Suspend users on hawk-mod@'s role, and with Organizational Units → Read added. Rachel gave the role the full Users → Update (not Create or Delete), accepting that it could also reset a non-admin's password. google-setup.md Part 4 says so, and the refusal message now names Users → Update. Also: "Clicking Suspend Google account suspends it" in the accounts alert; step 7 as built and the test in lifecycle-sync.md (status: steps 0-7 deployed); a step 7 paragraph in CLAUDE.md. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
tytremblay
approved these changes
Sep 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Step 7, part 5 of 5. Records the end-to-end test and closes out the step.
The test (2026-09-30)
On P0074, a throwaway mentor row, and
offboarding-test@, a throwaway account Rachel created:The Slack half (the deactivation reminder) was not tested: the test person was never put in Slack.
The privilege
Suspend was refused ("Not Authorized to access this resource/api") with only Users → Update → Suspend users on hawk-mod@'s role, and still refused with Organizational Units → Read added (which Google's role-to-privilege table lists beside it). Rachel decided to give the role the full Users → Update — not Create or Delete — accepting that it can also reset a non-admin's password. hawk-mod's code only ever changes
suspended.docs/google-setup.mdPart 4 now says exactly that, and the refusal message names Users → Update.Also
docs/lifecycle-sync.md: status "steps 0–7 deployed", step 7 as built, the two fixes found along the way (Held parent alert names grp-parents instead of "is in ." #58, Compare Gmail addresses the way Gmail does in the groups sync #59), and the test.CLAUDE.md: a step 7 paragraph.npm run typecheck && npm test && npm run format:check && npm run buildpass (842 tests).🤖 Generated with Claude Code