Keep the invite address on a request someone is on - #62
Merged
Merged
Conversation
A Slack invite request showed "Address to invite: …" only while open. "I'm on it" acknowledges the request, which redrew it without the address, so the person who had just taken the job lost the address they needed. The address line now stays until the request is resolved, which is what the hourly run does once the person is in Slack. It is still never in the summary, which /hawkmod findings and the morning report print. Fixes #60. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
tytremblay
approved these changes
Sep 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #60.
The bug. A Slack invite request in the onboarding channel shows "Address to invite:
…" only while the request isopen. I'm on it acknowledges it and redraws the message, so the address vanished at the moment the person who took the job needed it.The fix (
src/slack/alerts.ts,findingBlocks): show the address line until the request is resolved, which is what the hourly onboarding run does once the person appears in Slack. As the issue asks:/hawkmod findingsand the morning report print summaries wherever they run;Only
onboarding_slack_invitecarries the line (inviteAddressLinereturnsnullfor every other kind).Existing messages already acknowledged are not redrawn by this; they change only when the run next redraws or closes them. The address is on the lifecycle sheet meanwhile, so nothing needs backfilling.
Tests.
test/onboardingRequests.test.ts: the address test is renamed to the new rule and now checks an acknowledged request keeps the address beside "Acknowledged … is on it.", the summary never carries it, and a resolved one drops it. It fails onmainwithout the fix.npm run typecheck && npm test && npm run format:checkpass (842 tests). Independent of #61.🤖 Generated with Claude Code