Held parent alert names grp-parents instead of "is in ." - #58
Merged
Merged
Conversation
An address in grp-parents that no student lists at all was held with an empty group list, because the list names a person's own groups and leaves out their parents' entries. Finding #142 read "An address the lifecycle sheet does not account for, h…@gmail.com, is in . Nothing was removed." An unplaceable address now names every group it is held in, and a parent address adds "no student lists it as a parent". raise() redraws #142 in place at the next hourly groups run, without a new ping. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
willtoth
approved these changes
Sep 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A small fix found while reading open findings with Rachel on 2026-09-29, separate from the step 7 pull requests so it need not wait on them.
The bug. An address in
grp-parentsthat no student lists at all is held for a click, like any address the sheet does not account for. Its alert built the group list from the person's own groups, which leaves out parent entries — so for a parent address the list was empty. Finding #142 (open since 2026-09-28) reads:The fix. An unplaceable address names every group it is held in, and a parent address says why:
raise()redraws #142 in place at the next hourly groups run after deploy, without a new ping. Nothing about who is held, or what Remove from groups does, changes.Two tests in
test/lifecycleLeaving.test.ts; the parent one fails onmainwithout the fix.npm run typecheck && npm test && npm run format:checkpass (820 tests).🤖 Generated with Claude Code