feat: build Intel macOS SEA binaries alongside Apple Silicon - #1239
Merged
Conversation
macos-latest tracks GitHub's newest Apple Silicon image only; it stopped meaning Intel some releases ago. Adds macos-26-intel (a standard, non-large-runner image) as a fourth leg in the SEA binary matrix, so document-cli, document-mcp, and document-rest each ship a genuine Intel Mac build alongside the Apple Silicon one. Two legs now report process.platform === "darwin", so a name keyed by platform alone collides again exactly like the earlier Linux/ macOS collision this same script already fixed once. binaryFileName and buildSeaBinary now take an explicit architecture alongside the platform, and every binary's asset name carries both (document-cli-macos-arm64 vs document-cli-macos-x64). Also corrects a stale claim in the root README, left over from the earlier switch to node --build-sea, that this script still runs a signtool designature step on Windows -- it doesn't; --build-sea replaced that entirely.
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Contributor
|
🎉 This PR is included in version 5.10.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Contributor
|
🎉 This PR is included in version 4.12.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Contributor
|
🎉 This PR is included in version 1.2.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
macos-latest tracks GitHub's newest Apple Silicon image only -- it stopped meaning Intel some releases ago (confirmed against the actual runner image the current macos-latest build used: macos-26-arm64). Adds macos-26-intel, GitHub's current standard (not large-runner, no extra cost) Intel Mac image, as a fourth leg in the SEA binary matrix.
Two legs now both report process.platform === "darwin" (Apple Silicon and Intel), so a binary name keyed by platform alone collides again exactly like the earlier Linux/macOS collision (#1238) fixed once already. binaryFileName and buildSeaBinary now take an explicit architecture alongside the platform, so every binary's asset name carries both: document-cli-macos-arm64 vs document-cli-macos-x64, document-cli-linux-x64, document-cli-windows-x64.exe.
Verified locally end to end: built a real document-rest-test-macos-arm64 binary, signed it, ran it, and confirmed it serves real HTTP responses.
Also fixes a stale claim in the root README (left over from the earlier switch to node --build-sea) that this script still runs a signtool designature step on Windows -- it doesn't; --build-sea replaced that step entirely.