feat: build ARM64 Linux and Windows SEA binaries too - #1240
Merged
Conversation
Adds ubuntu-24.04-arm and windows-11-arm as two more legs in the SEA binary matrix, alongside the existing x64 Linux and Windows legs and the macOS Apple Silicon/Intel pair. Both are standard, non-large- runner GitHub-hosted images. Confirmed Node 26.8.1 ships official linux-arm64 and win-arm64 builds, so the existing "install a newer Node for the injection step" setup-node call resolves correctly on both without any change. binaryFileName already disambiguates by process.arch as well as platform (added for the earlier Intel/Apple Silicon macOS split), so document-cli-linux-arm64 and document-cli-windows-arm64.exe fall out with no further code change -- only the matrix itself needed extending.
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Contributor
|
🎉 This PR is included in version 5.11.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Contributor
|
🎉 This PR is included in version 4.13.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Contributor
|
🎉 This PR is included in version 1.3.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds ubuntu-24.04-arm and windows-11-arm as two more legs in the SEA binary matrix, alongside the existing x64 Linux/Windows legs and the macOS Apple Silicon/Intel pair (#1239). Both are standard, non-large-runner GitHub-hosted images.
Confirmed Node 26.8.1 ships official linux-arm64 and win-arm64 builds, so the existing "install a newer Node for the injection step" setup-node call resolves correctly on both without any change. Also checked document-cli/document-mcp/document-rest's own dependency trees for native-binding packages that might not be architecture-portable -- none found; the only arch-sensitive dependency in the mix (yoga-layout, via Ink) is WASM-based, not a native addon.
binaryFileName already disambiguates by process.arch as well as platform (added for the earlier Intel/Apple Silicon macOS split), so document-cli-linux-arm64 and document-cli-windows-arm64.exe fall out with no further code change -- only the matrix itself needed extending.