feat(core): cut the mcp bridge over to WireMeshTransport via createBridgeMesh - #58
Merged
Conversation
…idgeMesh Add createBridgeMesh(slot, coordinatorPort?), a shared factory wrapping identity load, MeshStore construction, and WireMeshTransport wiring in one call, replacing the inline TlsTransport-based block the mcp bridge previously built by hand. peerId is derived from deviceIdToHex(identity.deviceId) rather than the certificate fingerprint, matching the substrate swap's canonical device-id identity. The mcp bridge is the first of six bridges to move onto the new substrate, proving createBridgeMesh end to end before the remaining bridges migrate.
…ild step The test script ran node --test against a hardcoded list of ~20 dist/test/*.js paths, requiring a manual pnpm build before every run and manual list maintenance on every new test file. It also silently excluded federation.integration.test.ts and visibility.integration.test.ts from CI: their coverage lived only in test:federation/test:visibility, neither of which CI's test job ever invoked. Switch test to tsx --test against a src/test/**/*.test.ts glob, which resolves .js-suffixed imports to their .ts siblings and needs no compiled output. This picks up every *.test.ts file automatically, folding federation and visibility coverage into the suite CI actually runs, and removes the now-redundant test:federation/test:visibility scripts entirely. delivery-receipt.runner.ts spawned its own helper as a compiled dist/*.js file via plain node; point it at the .ts source instead and spawn via `node --import tsx` so it runs without a build step too.
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
🎉 This PR is included in version 1.32.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This was referenced Sep 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #47 (step 4 of P2's sequencing plan): cuts one bridge (mcp) over to the new WireMeshTransport substrate end to end, as the first real consumer before the remaining five bridges migrate.
createBridgeMesh(slot, coordinatorPort?): shared factory wrapping identity load,MeshStoreconstruction, andWireMeshTransportwiring, replacing the inlineTlsTransport-based block the mcp bridge previously built by hand.peerIdis nowdeviceIdToHex(identity.deviceId)rather than the certificate fingerprint.src/bridges/mcp/index.tsuses the new factory instead of constructingMeshStore/TlsTransportinline.bridge-mesh.test.tscoverspeerIdderivation,store.connectedafterinit(), and twocreateBridgeMeshinstances sharing acoordinatorPortseeing each other's registered agents.Also included, discovered and fixed while working this branch: the project's
testscript rannode --testagainst a hardcoded list of compileddist/test/*.jsfiles, requiring a manualpnpm buildfirst and manual list maintenance per new test file. It also silently excludedfederation.integration.test.tsandvisibility.integration.test.tsfrom CI, since neithertest:federationnortest:visibility(the only scripts that ran them) was ever part of CI'stestjob. Switchedtesttotsx --testagainst asrc/test/**/*.test.tsglob (resolves.js-suffixed imports to.tssiblings, no build step needed), which folds federation/visibility coverage into the suite CI runs and removes the now-redundant scripts.delivery-receipt.runner.ts's own helper spawn now targets the.tssource vianode --import tsxfor the same reason.All 92 tests pass via the new
pnpm test(up from 74 previously covered, now also including federation and visibility).