docs: mark the identity migration as a breaking change (agent-comms v2) - #62
Merged
Conversation
… change The Identity section still described the retired fingerprint-based peer-ID derivation (agent-comms#47's P2 substrate swap replaced it with the device-id already canonical in wire-mesh-core), and nothing in the project's own history had marked that change as breaking for semantic-release's benefit, so it shipped across several releases as ordinary patch/minor bumps despite orphaning every existing agent-comms identity on upgrade. BREAKING CHANGE: peer IDs are now derived from SHA-256 of the raw public key (device-id), not the SHA-256 fingerprint of the self-signed X.509 certificate. Every agent ID, room membership, and pending delivery queue tied to a pre-v2 identity is orphaned on upgrade, with no migration path. A v2 bridge cannot interoperate with a v1 one at all.
The hook still ran a partial manual build (build:frontend only, assuming dist/cli.js already existed from an earlier full build) then executed a single hardcoded compiled test file, dist/test/coordinator-socket-error.integration.test.js -- both left over from before the test suite moved to running directly against TypeScript source via tsx, with no build step. On a fresh checkout or worktree with no prior dist/ output, the hook failed outright on the missing dist/cli.js rather than running any real check. Runs eslint, tsc --noEmit, and the actual pnpm test suite directly against source, matching what test now means everywhere else in the project.
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
🎉 This PR is included in version 2.0.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Step 7 of #47's sequencing ("ship as agent-comms-v2"). The peer-id derivation change (certificate fingerprint -> device-id) that landed across #58-#61 is a genuine breaking change -- every existing agent-comms identity/agent-id is orphaned on upgrade, no migration path -- but none of those commits carried a
BREAKING CHANGE:footer, so semantic-release has been publishing them as ordinary patch/minor bumps (now v1.33.1) instead of a major version.Two commits:
.husky/pre-pushstill ran a partial manual build assumingdist/cli.jsalready existed from an earlier full build, then executed one hardcoded compiled test file (dist/test/coordinator-socket-error.integration.test.js) -- both left over from before the test suite moved to running directly against source via tsx. Failed outright on a fresh checkout with no priordist/. Now runs lint, typecheck, and the realpnpm testsuite directly.