This repository was archived by the owner on May 13, 2026. It is now read-only.
refactor(api/schema): unexport 3 internal response types - #1026
Merged
Conversation
SchemasByStateResponse, SchemasWithStateResponse, and SchemaStatusResponse are only used inside schemaClient.ts as return-type annotations on UnifiedSchemaClient methods. ts-unused-exports flagged them and grep across src confirms zero external references. Drop the `export` keyword on each; bodies, callers, and the exported function/class set are unchanged. Same pattern as #1024 / #1025. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
shiba4life
enabled auto-merge
May 12, 2026 23:57
4 tasks
github-merge-queue Bot
pushed a commit
that referenced
this pull request
May 13, 2026
…1027) ts-unused-exports flagged UPGRADE_POLL_INTERVAL_MS, UPGRADE_POLL_MAX_MS, and CANCELLED_BANNER_MS in CloudMigrationSettings.tsx. All four call sites are inside the same file; the colocated test file does not import them. Drop the `export` keyword on the three const declarations. Behavior-preserving — pure dead-export sweep. Continues the cleanup from #1014/#1015/#1017/#1018/#1022/#1023/#1024/#1025/#1026.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
SchemasByStateResponse,SchemasWithStateResponse, andSchemaStatusResponseinsrc/server/static-react/src/api/clients/schemaClient.tsare only used inside that file as return-type annotations onUnifiedSchemaClientmethods.ts-unused-exports tsconfig.jsonflagged all three;git grepacrosssrc/server/static-react/srcconfirms zero external references.This PR drops the
exportkeyword on each declaration. Bodies, callers, and the exported function/class set (UnifiedSchemaClient,createSchemaClient,getSchemasByState,getAllSchemasWithState,getSchemaStatus, etc.) are unchanged.Continues the dead-export cleanup from #1024 / #1025.
Diff
3
exportkeyword removals — same file, no behavior change.Verification
npm run typecheck— cleannpm run lint— clean (0 errors)npx ts-unused-exports tsconfig.json | grep schemaClient.ts— empty (no remaining unused exports in this file)npm test— 9 pre-existing flaky timeouts inMyProfileTab/MyIdentityCardPanel/ sample loaders (component tests untouched since refactor(ts): finish JS→TS migration — tests, configs, cleanup #826/refactor(ts): finish @ts-nocheck cleanup — 4 production + 38 test files #830); type-only change cannot affect runtime tests