Skip to content
This repository was archived by the owner on May 13, 2026. It is now read-only.

fix(query-form): wire schemasLoading to SelectField loading state #1021

Merged
shiba4life merged 1 commit into from
May 12, 2026
Merged

fix(query-form): wire schemasLoading to SelectField loading state #1021

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions src/server/static-react/src/components/query/QueryForm.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -87,6 +87,7 @@ function QueryForm({
value={queryState?.selectedSchema || ''}
onChange={handleSchemaChange}
options={buildSchemaOptions(approvedSchemas, orgNames)}
config={{ loading: schemasLoading }}
/>
</FieldWrapper>

Expand Down
5 changes: 3 additions & 2 deletions src/server/static-react/src/test/components/query/QueryForm.test.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -93,8 +93,9 @@ describe('QueryForm Component', () => {
mockProps.schemasLoading = true;
renderWithRedux(<QueryForm {...mockProps} />, { preloadedState: createAuthenticatedState() });

// The SelectField component should handle loading state
expect(screen.getByRole('combobox')).toBeInTheDocument();
// SelectField renders a loading indicator (no combobox) while schemasLoading is true
expect(screen.getByText('Loading...')).toBeInTheDocument();
expect(screen.queryByRole('combobox')).not.toBeInTheDocument();
});

it('should apply custom className', () => {
Expand Down
Loading