This repository was archived by the owner on May 13, 2026. It is now read-only.
fix(query-form): wire schemasLoading to SelectField loading state - #1021
Merged
Conversation
QueryForm destructured schemasLoading but never used it, tripping @typescript-eslint/no-unused-vars. SelectField already accepts config.loading and renders a spinner — pass schemasLoading through so the schema picker reflects the in-flight fetch. Also fix the now-meaningful loading test that previously asserted the combobox stayed present (it didn't — loading mode replaces it). Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
QueryForm.tsx:45destructuredschemasLoadingbut never used it, producing a@typescript-eslint/no-unused-varserror innpm run lint. Found incidentally during kanban 7758e / PR refactor(frontend): use BROWSER_CONFIG.STORAGE_KEYS.USER_HASH instead of literal 'fold_user_hash' #1020.SelectFieldalready supportsconfig.loading(renders a spinner). WiredschemasLoadingthrough — case (b) from the kanban prompt, 1-line fix.QueryForm.test.tsx:97was checking that the combobox stayed present in loading state (it never did — the assertion only passed because the prop was unwired). Now asserts the loading indicator is shown and the combobox is gone.Test plan
npm run lint— 0 errors (was 1), 89 warnings (unchanged, out of scope)npm run typecheck— cleannpm test— 788/788 pass🤖 Generated with Claude Code