-
Notifications
You must be signed in to change notification settings - Fork 0
Fix bugs and improve ci #57
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -55,6 +55,7 @@ apps = [ | |
| test = [ | ||
| "keyrings.alt", | ||
| "pytest", | ||
| "pytest-xdist", | ||
| "pytest-asyncio", | ||
| ] | ||
|
|
||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -308,10 +308,6 @@ def _set_context_panel_visible(self, visible: bool) -> None: | |
| ) | ||
|
|
||
| def _show_snapshot(self) -> None: | ||
| if not self._advanced_mode: | ||
| self._inspector_stack.setCurrentWidget(self._health_inspector) | ||
| self._context_panel.setHidden(True) | ||
| return | ||
| self._inspector_stack.setCurrentIndex(0) | ||
| self._context_panel.setHidden(True) | ||
|
|
||
|
|
@@ -604,8 +600,8 @@ def _request_advanced_mode(self, advanced: bool) -> None: | |
| def _apply_advanced_mode(self) -> None: | ||
| advanced = self._advanced_mode | ||
| self._destination_tabs.blockSignals(True) | ||
| self._destination_tabs.setTabVisible(2, advanced) | ||
| self._destination_tabs.setTabEnabled(2, advanced) | ||
| self._destination_tabs.setTabVisible(2, True) | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. |
||
| self._destination_tabs.setTabEnabled(2, True) | ||
| self._destination_tabs.blockSignals(False) | ||
| if not advanced and self._inspector_stack.currentIndex() == 0: | ||
| self._show_snapshot() | ||
|
|
@@ -1215,7 +1211,10 @@ async def _switch_broker_profile( | |
| await self._view_model.activate_broker_profile(profile_id, mqtt_config) | ||
| finally: | ||
| if self._view_model.active_broker_profile.id != previous_profile_id: | ||
| self._show_snapshot() | ||
| if self._advanced_mode: | ||
| self._show_snapshot() | ||
| else: | ||
| self._show_health() | ||
| self._render_connection_controls() | ||
|
|
||
| def _confirm_delete_broker_profile( | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When this broker already has a cached status or error, any
history_settings_changedemission clears_recording_loading, even if it came from a different broker while this broker's new request is still running. For example, after visiting both brokers, switching back to broker A and then completing a concurrent broker B load re-enables A's checkbox with stale cached state before A's refresh finishes; associate completion with the specific broker/request rather than treating cache presence as completion.AGENTS.md reference: AGENTS.md:L32-L32
Useful? React with 👍 / 👎.