Fix bugs and improve ci - #57
Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 4a40bacf86
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| if ( | ||
| self._view_model.history_recording_status_for(broker_id) is not None | ||
| or self._view_model.history_settings_error_for(broker_id) is not None | ||
| ): |
There was a problem hiding this comment.
When this broker already has a cached status or error, any history_settings_changed emission clears _recording_loading, even if it came from a different broker while this broker's new request is still running. For example, after visiting both brokers, switching back to broker A and then completing a concurrent broker B load re-enables A's checkbox with stale cached state before A's refresh finishes; associate completion with the specific broker/request rather than treating cache presence as completion.
AGENTS.md reference: AGENTS.md:L32-L32
Useful? React with 👍 / 👎.
| self._destination_tabs.blockSignals(True) | ||
| self._destination_tabs.setTabVisible(2, advanced) | ||
| self._destination_tabs.setTabEnabled(2, advanced) | ||
| self._destination_tabs.setTabVisible(2, True) |
There was a problem hiding this comment.
This is a placeholder and should not be here.
Useful? React with 👍 / 👎.
| self._destination_tabs.blockSignals(True) | ||
| self._destination_tabs.setTabVisible(2, advanced) | ||
| self._destination_tabs.setTabEnabled(2, advanced) | ||
| self._destination_tabs.setTabVisible(2, True) |
There was a problem hiding this comment.
<valid Markdown explaining why this is a problem; cite files/lines/functions>
Useful? React with 👍 / 👎.
1 participant
No description provided.