Stop proposing dependency floors this project cannot install - #23
Merged
Conversation
The dev-tooling group raised the mypy floor to 2.3.1, which requires Python >=3.11. CI tests 3.9 through 3.13, so that leg failed at install in 41 seconds while the other four passed in about three minutes each. Not a flake, and a re-run does not fix it: the floor cannot move until 3.9 is dropped, and that is a decision about the support matrix rather than about a linter. update-types does not help, for the reason already written into lemma's configuration: for a `>=` constraint Dependabot files a "requirement update", which that filter does not match. So the ignore is unconditional. tqdm, onnx and onnxruntime are ignored for the other reason. Their lower bounds describe what a user may already have installed, not what CI resolves - pip takes the newest match either way. Raising them locks people out and changes nothing that gets tested, so they should move when the code needs a newer API, not on a schedule.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The dev-tooling group in #17 raised the
mypyfloor to 2.3.1, which requires Python ≥3.11:CI tests 3.9 through 3.13. The
py3.9leg failed at install in 41 seconds, before a single test ran, while the other four passed in about three minutes each. Not a flake, and a re-run does not fix it — the floor cannot move until 3.9 is dropped, and that is a decision about the support matrix rather than about a linter.update-typesdoes not help, for the reason already written into lemma's configuration: for a>=constraint Dependabot files a requirement update, which that filter does not match. So the ignore is unconditional.The other three
tqdm,onnxandonnxruntimeare ignored for a different reason, and it is the one stated in lemma's config in your own words: a lower bound describes what a user may already have installed, not what CI resolves. pip takes the newest match either way, so raising the floor locks people out and changes nothing that gets tested.All three are genuinely imported — this is not the praxis case where the dependency was unused. They should move when the code needs a newer API, not on a schedule.
Effect
Dependabot closes its own open PRs for a dependency once it becomes ignored, so #18, #20 and #21 should disappear on their own after this lands. #17 is already closed with the install log.
The existing entries —
torchpinned outright,numpyandgymnasiummajors — are untouched.