Make the numpy and gymnasium ignores actually work, and add pytest - #31
Open
DenisDrobyshev wants to merge 2 commits into
Open
Make the numpy and gymnasium ignores actually work, and add pytest#31DenisDrobyshev wants to merge 2 commits into
DenisDrobyshev wants to merge 2 commits into
Conversation
My own change in #23 left these two on update-types: ["version-update: semver-major"], which does not do what it looks like it does. #29 raised numpy from >=1.21 to >=2.2.6 and walked straight past it, because for a `>=` constraint Dependabot files a "requirement update" rather than a version update - the behaviour already written into lemma's configuration and which I copied only half of. pytest joins mypy for the other reason: pytest 9 requires Python >=3.10 and mypy 2.3 requires >=3.11, so both fail the 3.9 leg at install. Ignoring them is a holding action, not an answer - #30 is about the support matrix that is actually causing this.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
My own change in #23 left
numpyandgymnasiumonupdate-types: ["version-update:semver-major"], which does not do what it looks like it does.#29 raised
numpyfrom>=1.21to>=2.2.6and walked straight past that filter — a two-major jump. For a>=constraint Dependabot files a requirement update rather than a version update, soupdate-typesnever matches. That behaviour is already written into lemma'sdependabot.yml; I copied half the lesson and left these two entries as they were.Now unconditional, like
torchbeside them.pytest
Joins
mypyfor the other reason.pytest9 requires Python ≥3.10 andmypy2.3 requires ≥3.11, so both fail the 3.9 leg at install — #17 and #25, closed today, 41s and 44s respectively while every other leg passed.Ignoring them is a holding action rather than an answer. #30 is about the constraint actually causing it:
requires-python = ">=3.9", with 3.9 unsupported upstream since October 2025 and the toolchain frozen behind it. That is a user-facing support decision, so it is an issue rather than a pull request.