chore(antithesis): Frechet Distance and intake rework by blt · Pull Request #2228 · DataDog/saluki

blt · 2026-07-28T23:39:08Z

Summary

This commit introduces the Frechet distance calculation into the
differential scenario, allowing us to determine if ADP-on and ADP-off
emit equivalent series for all input sequences. The distance calculation
has been chosen to be mathematically defensible and also to have the
right visual check for our latent understanding of what 'equivalent' series
look like in practice.

Change Type

Bug fix
New feature
Non-functional (chore, refactoring, docs)
Performance

How did you test this PR?

References

blt · 2026-07-28T23:39:25Z

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

This stack of pull requests is managed by Graphite. Learn more about stacking.

pr-commenter · 2026-07-28T23:46:25Z

Binary Size Analysis (Agent Data Plane)

Baseline: 7f0ba13 · Comparison: 9b14f24 · diff
Analysis Configuration: stripped binaries · Pass/Fail Threshold: +5%
Sizes: 41.60 MiB (baseline) vs 41.60 MiB (comparison)
Size Change: +0 B (+0.00%)

✅ Binary size difference within threshold

Changes by Module

Module	File Size	Symbols
`anon.44a0faa3240fa409baa379409d152aec.1.llvm.17202424994989785089`	-130 B	1
`anon.44a0faa3240fa409baa379409d152aec.1.llvm.9448702623715800387`	+129 B	1
`anon.44a0faa3240fa409baa379409d152aec.4.llvm.17202424994989785089`	-114 B	1
`anon.44a0faa3240fa409baa379409d152aec.4.llvm.9448702623715800387`	+113 B	1
`anon.44a0faa3240fa409baa379409d152aec.3.llvm.17202424994989785089`	-109 B	1
`anon.44a0faa3240fa409baa379409d152aec.3.llvm.9448702623715800387`	+108 B	1
`anon.44a0faa3240fa409baa379409d152aec.0.llvm.17202424994989785089`	-97 B	1
`anon.44a0faa3240fa409baa379409d152aec.0.llvm.9448702623715800387`	+96 B	1
`anon.44a0faa3240fa409baa379409d152aec.2.llvm.17202424994989785089`	-95 B	1
`anon.44a0faa3240fa409baa379409d152aec.2.llvm.9448702623715800387`	+94 B	1
`[Unmapped]`	+5 B	1

Detailed Symbol Changes

    FILE SIZE        VM SIZE    
 --------------  -------------- 
  [NEW]    +129  [NEW]     +40    anon.44a0faa3240fa409baa379409d152aec.1.llvm.9448702623715800387
  [NEW]    +113  [NEW]     +24    anon.44a0faa3240fa409baa379409d152aec.4.llvm.9448702623715800387
  [NEW]    +108  [NEW]     +19    anon.44a0faa3240fa409baa379409d152aec.3.llvm.9448702623715800387
  [NEW]     +96  [NEW]      +7    anon.44a0faa3240fa409baa379409d152aec.0.llvm.9448702623715800387
  [NEW]     +94  [NEW]      +5    anon.44a0faa3240fa409baa379409d152aec.2.llvm.9448702623715800387
   +10%      +5  [ = ]       0    [Unmapped]
  [DEL]     -95  [DEL]      -5    anon.44a0faa3240fa409baa379409d152aec.2.llvm.17202424994989785089
  [DEL]     -97  [DEL]      -7    anon.44a0faa3240fa409baa379409d152aec.0.llvm.17202424994989785089
  [DEL]    -109  [DEL]     -19    anon.44a0faa3240fa409baa379409d152aec.3.llvm.17202424994989785089
  [DEL]    -114  [DEL]     -24    anon.44a0faa3240fa409baa379409d152aec.4.llvm.17202424994989785089
  [DEL]    -130  [DEL]     -40    anon.44a0faa3240fa409baa379409d152aec.1.llvm.17202424994989785089
  [ = ]       0  [ = ]       0    TOTAL

pr-commenter · 2026-07-29T00:05:57Z

Regression Detector (Agent Data Plane)

Run ID: 7242981a-da59-4f9f-84da-c7f86588f75d
Baseline: 7f0ba132 · Comparison: 9b14f242 · diff

Optimization Goals: ✅ No significant changes detected

Fine details of change detection per experiment (5)

Experiments configured erratic: true are tagged (ignored) and skipped when determining which experiments regressed or improved. Experiments which are detected as erratic at runtime are tagged (erratic) to flag that the run's sample dispersion was high, but their regression / improvement signal still counts.

experiment	goal	Δ mean %	links
quality_gates_rss_dsd_heavy	memory	⚪ +0.26	metrics profiles logs
quality_gates_rss_idle	memory	⚪ +0.00	metrics profiles logs
quality_gates_rss_dsd_ultraheavy	memory	⚪ -0.01	metrics profiles logs
quality_gates_rss_dsd_medium	memory	⚪ -0.07	metrics profiles logs
quality_gates_rss_dsd_low	memory	⚪ -0.27	metrics profiles logs

Bounds Checks: ✅ Passed (5)

experiment	check	replicates	observed	links
quality_gates_rss_dsd_heavy	memory_usage	10/10	✅ 143 MiB ≤ 145 MiB	metrics profiles logs
quality_gates_rss_dsd_low	memory_usage	10/10	✅ 48.9 MiB ≤ 50 MiB	metrics profiles logs
quality_gates_rss_dsd_medium	memory_usage	10/10	✅ 75.6 MiB ≤ 80 MiB	metrics profiles logs
quality_gates_rss_dsd_ultraheavy	memory_usage	10/10	✅ 202 MiB ≤ 205 MiB	metrics profiles logs
quality_gates_rss_idle	memory_usage	10/10	✅ 31.8 MiB ≤ 40 MiB	metrics profiles logs

Explanation

A change is flagged as a regression when |Δ mean %| > 5.00% in the regressing direction for its optimization goal AND SMP marks the experiment as a regression (is_regression: true). Improvements use the matching criteria for the improving direction. Experiments configured erratic: true (tagged (ignored)) are skipped outright; experiments detected as erratic at runtime (tagged (erratic)) still count, since that flag describes sample dispersion rather than directional certainty. The Δ mean % cell is colored accordingly: 🟢 = improvement, 🔴 = regression, ⚪ = neutral. Reduction in CPU or memory is an improvement; reduction in ingress throughput is a regression.

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 82feb2c0b2

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: b25826a1cd

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 49cf71c7b1

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 84df7c4dd7

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 5eb7267eff

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 4d5058bdac

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: ebe1b03f0d

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 87b8a698c8

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 5c990e26d8

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: bb145b60c6

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 8c9fb2439f

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: aa0978f3d2

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 4f62b802cd

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

chatgpt-codex-connector · 2026-08-01T00:11:49Z

+                    return;
+                }
+                *weight += w;
+                *mean += (point.value - *mean) * (w / *weight);


Keep opposite-sign rates finite while averaging

When a bucket contains multiple positive-interval rate points with large opposite signs, this update still overflows in point.value - *mean; for example, both [f64::MAX, f64::MIN] and [f64::MAX, -f64::MAX / 2.0] fold to -inf even though their representable means are 0 and f64::MAX / 4.0. The workload explicitly samples both finite extrema, and distance treats matching infinities as agreement, so a real lane divergence can pass the differential assertion. Fresh evidence relative to the prior weighting comment is that the replacement running-mean formula removed multiplication overflow but retained subtraction overflow; rescale the operands or use another overflow-safe weighted-mean update.

AGENTS.md reference: test/antithesis/AGENTS.md:L46-L49

Useful? React with 👍 / 👎.

This commit introduces the Frechet distance calculation into the differential scenario, allowing us to determine if ADP-on and ADP-off emit equivalent series for all input sequences. The distance calculation has been chosen to be mathematically defensible and also to have the right visual check for our latent understanding of what 'equivalent' series look like in practice.

webern

Rubber stamp since it's all harness code 🕹️

dd-octo-sts Bot added the area/test All things testing: unit/integration, correctness, SMP regression, etc. label Jul 28, 2026

blt mentioned this pull request Jul 28, 2026

chore(antithesis): Add provider_kind in sample config #2218

Open

4 tasks

This comment has been minimized.

Sign in to view

blt marked this pull request as ready for review July 29, 2026 16:47

blt requested a review from a team as a code owner July 29, 2026 16:47

blt force-pushed the blt/chore_antithesis_frechet_distance_and_intake_rework branch from ba9004d to 82feb2c Compare July 29, 2026 16:47

blt requested review from a team as code owners July 29, 2026 16:47

blt force-pushed the blt/chore_antithesis_frechet_distance_and_intake_rework branch from 82feb2c to 8728f6c Compare July 29, 2026 16:48

chatgpt-codex-connector Bot reviewed Jul 29, 2026

View reviewed changes

blt force-pushed the blt/chore_antithesis_frechet_distance_and_intake_rework branch from 8728f6c to b25826a Compare July 29, 2026 17:05

chatgpt-codex-connector Bot reviewed Jul 29, 2026

View reviewed changes

Comment thread test/antithesis/intake/src/capture.rs

Comment thread test/antithesis/intake/src/series.rs Outdated

Comment thread test/antithesis/intake/src/sketch.rs

Comment thread test/antithesis/intake/src/series.rs

blt force-pushed the blt/chore_antithesis_frechet_distance_and_intake_rework branch from b25826a to 352e269 Compare July 29, 2026 17:15

blt force-pushed the blt/chore_antithesis_add_provider_kind_in_sample_config branch 2 times, most recently from 98dc187 to aaebc86 Compare July 29, 2026 20:37

blt force-pushed the blt/chore_antithesis_frechet_distance_and_intake_rework branch from 352e269 to 49cf71c Compare July 29, 2026 20:37

chatgpt-codex-connector Bot reviewed Jul 29, 2026

View reviewed changes

Comment thread test/antithesis/intake/src/sketch.rs

blt force-pushed the blt/chore_antithesis_add_provider_kind_in_sample_config branch from aaebc86 to 986783b Compare July 29, 2026 20:50

blt force-pushed the blt/chore_antithesis_frechet_distance_and_intake_rework branch from 49cf71c to 84df7c4 Compare July 29, 2026 20:50

chatgpt-codex-connector Bot reviewed Jul 29, 2026

View reviewed changes

Comment thread test/antithesis/intake/src/sketch.rs Outdated

blt force-pushed the blt/chore_antithesis_add_provider_kind_in_sample_config branch from 986783b to e607b72 Compare July 29, 2026 21:18

blt force-pushed the blt/chore_antithesis_frechet_distance_and_intake_rework branch from 84df7c4 to 42d9ed1 Compare July 29, 2026 21:18

chatgpt-codex-connector Bot reviewed Jul 30, 2026

View reviewed changes

Comment thread test/antithesis/intake/src/capture.rs

Comment thread test/antithesis/intake/src/series.rs Outdated

blt force-pushed the blt/chore_antithesis_frechet_distance_and_intake_rework branch from 5eb7267 to 3fa6ad4 Compare July 30, 2026 21:05

blt force-pushed the blt/chore_antithesis_add_provider_kind_in_sample_config branch from d9f7f33 to b7a894e Compare July 30, 2026 21:05

blt force-pushed the blt/chore_antithesis_frechet_distance_and_intake_rework branch from 3fa6ad4 to f0318e1 Compare July 30, 2026 21:19

blt force-pushed the blt/chore_antithesis_add_provider_kind_in_sample_config branch from b7a894e to 7b80b84 Compare July 30, 2026 21:19

blt force-pushed the blt/chore_antithesis_frechet_distance_and_intake_rework branch from f0318e1 to 32dd7ae Compare July 30, 2026 22:20

blt force-pushed the blt/chore_antithesis_add_provider_kind_in_sample_config branch from 7b80b84 to f96c13f Compare July 30, 2026 22:20

blt force-pushed the blt/chore_antithesis_frechet_distance_and_intake_rework branch from 32dd7ae to 3be9402 Compare July 30, 2026 22:24

blt force-pushed the blt/chore_antithesis_add_provider_kind_in_sample_config branch 2 times, most recently from 57141a5 to 91e00cc Compare July 30, 2026 22:24

blt force-pushed the blt/chore_antithesis_frechet_distance_and_intake_rework branch 2 times, most recently from a69729f to 4d5058b Compare July 31, 2026 15:04

blt force-pushed the blt/chore_antithesis_add_provider_kind_in_sample_config branch from 91e00cc to 335b960 Compare July 31, 2026 15:04

chatgpt-codex-connector Bot reviewed Jul 31, 2026

View reviewed changes

Comment thread test/antithesis/intake/src/sketch.rs

Comment thread test/antithesis/intake/src/sketch.rs Outdated

blt force-pushed the blt/chore_antithesis_frechet_distance_and_intake_rework branch from 4d5058b to 0997c6e Compare July 31, 2026 15:26

blt force-pushed the blt/chore_antithesis_add_provider_kind_in_sample_config branch from 335b960 to a07c2b7 Compare July 31, 2026 15:26

blt force-pushed the blt/chore_antithesis_frechet_distance_and_intake_rework branch from 0997c6e to ebe1b03 Compare July 31, 2026 15:27

blt force-pushed the blt/chore_antithesis_add_provider_kind_in_sample_config branch from a07c2b7 to 9d4c44d Compare July 31, 2026 15:27

chatgpt-codex-connector Bot reviewed Jul 31, 2026

View reviewed changes

Comment thread test/antithesis/intake/src/series.rs Outdated

blt force-pushed the blt/chore_antithesis_frechet_distance_and_intake_rework branch 2 times, most recently from 71edde4 to 87b8a69 Compare July 31, 2026 17:06

chatgpt-codex-connector Bot reviewed Jul 31, 2026

View reviewed changes

Comment thread test/antithesis/intake/src/series.rs Outdated

Comment thread test/antithesis/intake/src/series.rs Outdated

Comment thread test/antithesis/scenarios/differential/src/bin/eventually_differential_series.rs

blt force-pushed the blt/chore_antithesis_frechet_distance_and_intake_rework branch from 87b8a69 to 5c990e2 Compare July 31, 2026 17:22

chatgpt-codex-connector Bot reviewed Jul 31, 2026

View reviewed changes

Comment thread test/antithesis/intake/src/sketch.rs Outdated

chatgpt-codex-connector Bot reviewed Jul 31, 2026

View reviewed changes

Comment thread test/antithesis/intake/src/series.rs Outdated

Comment thread test/antithesis/intake/README.md Outdated

Comment thread test/antithesis/intake/src/sketch.rs Outdated

chatgpt-codex-connector Bot reviewed Jul 31, 2026

View reviewed changes

Comment thread test/antithesis/intake/src/series.rs

Comment thread test/antithesis/intake/src/series.rs

Comment thread test/antithesis/intake/src/capture.rs

Comment thread test/antithesis/intake/src/series.rs Outdated

chatgpt-codex-connector Bot reviewed Jul 31, 2026

View reviewed changes

Comment thread test/antithesis/intake/src/sketch.rs

Comment thread test/antithesis/intake/src/http/antithesis.rs

Comment thread test/antithesis/intake/README.md

Comment thread test/antithesis/intake/README.md

chatgpt-codex-connector Bot reviewed Aug 1, 2026

View reviewed changes

webern approved these changes Aug 5, 2026

View reviewed changes

Uh oh!

Conversation

blt commented Jul 28, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Change Type

How did you test this PR?

References

Uh oh!

blt commented Jul 28, 2026

Uh oh!

This comment has been minimized.

pr-commenter Bot commented Jul 28, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Binary Size Analysis (Agent Data Plane)

✅ Binary size difference within threshold

Uh oh!

pr-commenter Bot commented Jul 29, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Regression Detector (Agent Data Plane)

Optimization Goals: ✅ No significant changes detected

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

Uh oh!

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

blt commented Jul 28, 2026 •

edited

Loading

pr-commenter Bot commented Jul 28, 2026 •

edited

Loading

pr-commenter Bot commented Jul 29, 2026 •

edited

Loading