Skip to content

chore(antithesis): Add provider_kind in sample config - #2218

Open
blt wants to merge 1 commit into
blt/chore_antithesis_is_malformed_based_load_generationfrom
blt/chore_antithesis_add_provider_kind_in_sample_config
Open

chore(antithesis): Add provider_kind in sample config#2218
blt wants to merge 1 commit into
blt/chore_antithesis_is_malformed_based_load_generationfrom
blt/chore_antithesis_add_provider_kind_in_sample_config

Conversation

@blt

@blt blt commented Jul 27, 2026

Copy link
Copy Markdown
Contributor

Summary

Pyld54 asserts a v3 tagset back-reference resolves to an earlier
tagset. Agent emits that back-reference only when a metric carries both
a shared prefix tagset and its own tags. Previously we only ever emitted
load that carried no shared prefix.

This commit adds provider_kind into the sampled datadog.yaml. Agent will
attach this as a global tag which acts as a shared prefix. 1/3 of
configs will not have provider_kind present.

Change Type

  • Bug fix
  • New feature
  • Non-functional (chore, refactoring, docs)
  • Performance

How did you test this PR?

References

blt commented Jul 27, 2026

Copy link
Copy Markdown
Contributor Author

@dd-octo-sts dd-octo-sts Bot added the area/test All things testing: unit/integration, correctness, SMP regression, etc. label Jul 27, 2026
@datadog-prod-us1-4

This comment has been minimized.

@pr-commenter

pr-commenter Bot commented Jul 27, 2026

Copy link
Copy Markdown

Binary Size Analysis (Agent Data Plane)

Baseline: 7f0ba13 · Comparison: 1d9b68e · diff
Analysis Configuration: stripped binaries · Pass/Fail Threshold: +5%
Sizes: 41.60 MiB (baseline) vs 41.60 MiB (comparison)
Size Change: +0 B (+0.00%)

✅ Binary size difference within threshold

Changes by Module
Module File Size Symbols
anon.44a0faa3240fa409baa379409d152aec.1.llvm.17202424994989785089 -130 B 1
anon.44a0faa3240fa409baa379409d152aec.1.llvm.9660746951319598755 +129 B 1
anon.44a0faa3240fa409baa379409d152aec.4.llvm.17202424994989785089 -114 B 1
anon.44a0faa3240fa409baa379409d152aec.4.llvm.9660746951319598755 +113 B 1
anon.44a0faa3240fa409baa379409d152aec.3.llvm.17202424994989785089 -109 B 1
anon.44a0faa3240fa409baa379409d152aec.3.llvm.9660746951319598755 +108 B 1
anon.44a0faa3240fa409baa379409d152aec.0.llvm.17202424994989785089 -97 B 1
anon.44a0faa3240fa409baa379409d152aec.0.llvm.9660746951319598755 +96 B 1
anon.44a0faa3240fa409baa379409d152aec.2.llvm.17202424994989785089 -95 B 1
anon.44a0faa3240fa409baa379409d152aec.2.llvm.9660746951319598755 +94 B 1
[Unmapped] +5 B 1
Detailed Symbol Changes
    FILE SIZE        VM SIZE    
 --------------  -------------- 
  [NEW]    +129  [NEW]     +40    anon.44a0faa3240fa409baa379409d152aec.1.llvm.9660746951319598755
  [NEW]    +113  [NEW]     +24    anon.44a0faa3240fa409baa379409d152aec.4.llvm.9660746951319598755
  [NEW]    +108  [NEW]     +19    anon.44a0faa3240fa409baa379409d152aec.3.llvm.9660746951319598755
  [NEW]     +96  [NEW]      +7    anon.44a0faa3240fa409baa379409d152aec.0.llvm.9660746951319598755
  [NEW]     +94  [NEW]      +5    anon.44a0faa3240fa409baa379409d152aec.2.llvm.9660746951319598755
   +10%      +5  [ = ]       0    [Unmapped]
  [DEL]     -95  [DEL]      -5    anon.44a0faa3240fa409baa379409d152aec.2.llvm.17202424994989785089
  [DEL]     -97  [DEL]      -7    anon.44a0faa3240fa409baa379409d152aec.0.llvm.17202424994989785089
  [DEL]    -109  [DEL]     -19    anon.44a0faa3240fa409baa379409d152aec.3.llvm.17202424994989785089
  [DEL]    -114  [DEL]     -24    anon.44a0faa3240fa409baa379409d152aec.4.llvm.17202424994989785089
  [DEL]    -130  [DEL]     -40    anon.44a0faa3240fa409baa379409d152aec.1.llvm.17202424994989785089
  [ = ]       0  [ = ]       0    TOTAL

@blt
blt marked this pull request as ready for review July 27, 2026 23:24
@blt
blt requested review from a team as code owners July 27, 2026 23:24
@pr-commenter

pr-commenter Bot commented Jul 27, 2026

Copy link
Copy Markdown

Regression Detector (Agent Data Plane)

Run ID: d82975bc-6cba-4f87-8f42-85a30506078f
Baseline: 7f0ba132 · Comparison: 1d9b68ec · diff

Optimization Goals: ✅ No significant changes detected

Fine details of change detection per experiment (5)

Experiments configured erratic: true are tagged (ignored) and skipped when determining which experiments regressed or improved. Experiments which are detected as erratic at runtime are tagged (erratic) to flag that the run's sample dispersion was high, but their regression / improvement signal still counts.

experiment goal Δ mean % links
quality_gates_rss_dsd_heavy memory ⚪ +0.09 metrics profiles logs
quality_gates_rss_idle memory ⚪ -0.02 metrics profiles logs
quality_gates_rss_dsd_low memory ⚪ -0.15 metrics profiles logs
quality_gates_rss_dsd_medium memory ⚪ -0.17 metrics profiles logs
quality_gates_rss_dsd_ultraheavy memory ⚪ -0.30 metrics profiles logs
Bounds Checks: ✅ Passed (5)
experiment check replicates observed links
quality_gates_rss_dsd_heavy memory_usage 10/10 ✅ 141 MiB ≤ 145 MiB metrics profiles logs
quality_gates_rss_dsd_low memory_usage 10/10 ✅ 49.2 MiB ≤ 50 MiB metrics profiles logs
quality_gates_rss_dsd_medium memory_usage 10/10 ✅ 77.4 MiB ≤ 80 MiB metrics profiles logs
quality_gates_rss_dsd_ultraheavy memory_usage 10/10 ✅ 202 MiB ≤ 205 MiB metrics profiles logs
quality_gates_rss_idle memory_usage 10/10 ✅ 31.7 MiB ≤ 40 MiB metrics profiles logs
Explanation

A change is flagged as a regression when |Δ mean %| > 5.00% in the regressing direction for its optimization goal AND SMP marks the experiment as a regression (is_regression: true). Improvements use the matching criteria for the improving direction. Experiments configured erratic: true (tagged (ignored)) are skipped outright; experiments detected as erratic at runtime (tagged (erratic)) still count, since that flag describes sample dispersion rather than directional certainty. The Δ mean % cell is colored accordingly: 🟢 = improvement, 🔴 = regression, ⚪ = neutral. Reduction in CPU or memory is an improvement; reduction in ingress throughput is a regression.

@datadog-prod-us1-4 datadog-prod-us1-4 Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Datadog Autotest: PASS

More details

The sampled provider_kind values are valid Agent configuration values, and the empty branch is omitted so existing timelines retain the default behavior. The change is isolated to Antithesis config generation; no behavioral regression or diff-only production hazard was identified.

Was this helpful? React 👍 or 👎

Open Bits AI session

🤖 Datadog Autotest · Commit 14ee8b4 · What is Autotest? · @DataDog review to ask questions · Any feedback? Reach out in #autotest

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 14ee8b4347

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread test/antithesis/harness/src/config.rs Outdated
@blt
blt force-pushed the blt/chore_antithesis_is_malformed_based_load_generation branch from 43cf97d to 86e0959 Compare July 29, 2026 17:15
@blt
blt force-pushed the blt/chore_antithesis_add_provider_kind_in_sample_config branch 2 times, most recently from 98dc187 to aaebc86 Compare July 29, 2026 20:37
@blt
blt force-pushed the blt/chore_antithesis_is_malformed_based_load_generation branch 2 times, most recently from 793eced to 2a19b2e Compare July 29, 2026 20:50
@blt
blt force-pushed the blt/chore_antithesis_add_provider_kind_in_sample_config branch 2 times, most recently from 986783b to e607b72 Compare July 29, 2026 21:18
@blt
blt force-pushed the blt/chore_antithesis_is_malformed_based_load_generation branch 2 times, most recently from 74d04b8 to fdea3d5 Compare July 29, 2026 22:42
@blt
blt force-pushed the blt/chore_antithesis_add_provider_kind_in_sample_config branch 2 times, most recently from d06009f to 65092dd Compare July 29, 2026 22:55
@blt
blt force-pushed the blt/chore_antithesis_is_malformed_based_load_generation branch 2 times, most recently from 52ca146 to 9cf8925 Compare July 29, 2026 23:00
@blt
blt force-pushed the blt/chore_antithesis_add_provider_kind_in_sample_config branch from 65092dd to a53d037 Compare July 29, 2026 23:00
@blt
blt force-pushed the blt/chore_antithesis_is_malformed_based_load_generation branch from 9cf8925 to 686f983 Compare July 29, 2026 23:06
@blt
blt force-pushed the blt/chore_antithesis_is_malformed_based_load_generation branch from f3e05f8 to da6321e Compare July 30, 2026 15:24
@blt
blt force-pushed the blt/chore_antithesis_add_provider_kind_in_sample_config branch from 7e2743b to 0b329dc Compare July 30, 2026 15:24
@blt
blt force-pushed the blt/chore_antithesis_is_malformed_based_load_generation branch from da6321e to c01556e Compare July 30, 2026 15:57
@blt
blt force-pushed the blt/chore_antithesis_add_provider_kind_in_sample_config branch 2 times, most recently from 4795d53 to d9f7f33 Compare July 30, 2026 20:40
@blt
blt force-pushed the blt/chore_antithesis_is_malformed_based_load_generation branch from c01556e to d9441ef Compare July 30, 2026 20:40
@blt
blt force-pushed the blt/chore_antithesis_add_provider_kind_in_sample_config branch from d9f7f33 to b7a894e Compare July 30, 2026 21:05
@blt
blt force-pushed the blt/chore_antithesis_is_malformed_based_load_generation branch 2 times, most recently from f670417 to 9f6682e Compare July 30, 2026 21:19
@blt
blt force-pushed the blt/chore_antithesis_add_provider_kind_in_sample_config branch 2 times, most recently from 7b80b84 to f96c13f Compare July 30, 2026 22:20
@blt
blt force-pushed the blt/chore_antithesis_is_malformed_based_load_generation branch 2 times, most recently from 90c9988 to f207c9c Compare July 30, 2026 22:24
@blt
blt force-pushed the blt/chore_antithesis_add_provider_kind_in_sample_config branch 2 times, most recently from 57141a5 to 91e00cc Compare July 30, 2026 22:24
@blt
blt force-pushed the blt/chore_antithesis_is_malformed_based_load_generation branch 2 times, most recently from 7e3d076 to c5e7907 Compare July 31, 2026 15:04
@blt
blt force-pushed the blt/chore_antithesis_add_provider_kind_in_sample_config branch from 91e00cc to 335b960 Compare July 31, 2026 15:04
@blt
blt force-pushed the blt/chore_antithesis_is_malformed_based_load_generation branch from c5e7907 to 7fc724f Compare July 31, 2026 15:26
@blt
blt force-pushed the blt/chore_antithesis_add_provider_kind_in_sample_config branch 2 times, most recently from a07c2b7 to 9d4c44d Compare July 31, 2026 15:27
@blt
blt force-pushed the blt/chore_antithesis_is_malformed_based_load_generation branch from 7fc724f to 8d1cf98 Compare July 31, 2026 18:26
@blt
blt force-pushed the blt/chore_antithesis_add_provider_kind_in_sample_config branch from 9d4c44d to 2a18400 Compare July 31, 2026 18:26
@blt
blt force-pushed the blt/chore_antithesis_is_malformed_based_load_generation branch from 8d1cf98 to 5f2c894 Compare July 31, 2026 22:51
@blt
blt force-pushed the blt/chore_antithesis_add_provider_kind_in_sample_config branch from 2a18400 to 1fb6bb7 Compare July 31, 2026 22:51
@blt
blt force-pushed the blt/chore_antithesis_is_malformed_based_load_generation branch from 5f2c894 to 0f55ac4 Compare August 3, 2026 18:35
Pyld54 asserts a v3 tagset back-reference resolves to an earlier
tagset. Agent emits that back-reference only when a metric carries both
a shared prefix tagset and its own tags. Previously we only ever emitted
load that carried no shared prefix.

This commit adds provider_kind into the sampled datadog.yaml. Agent will
attach this as a global tag which acts as a shared prefix. 1/3 of
configs will not have provider_kind present.
@blt
blt force-pushed the blt/chore_antithesis_add_provider_kind_in_sample_config branch from 1fb6bb7 to 1d9b68e Compare August 3, 2026 18:36

@tobz tobz left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

(Approved in spite of the CI error since that's coming from the ancestor PR.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/test All things testing: unit/integration, correctness, SMP regression, etc.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants