chore(antithesis): Add provider_kind in sample config - #2218
Conversation
|
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
This stack of pull requests is managed by Graphite. Learn more about stacking. |
This comment has been minimized.
This comment has been minimized.
Binary Size Analysis (Agent Data Plane)Baseline: 7f0ba13 · Comparison: 1d9b68e · diff ✅ Binary size difference within thresholdChanges by Module
Detailed Symbol Changes |
Regression Detector (Agent Data Plane)Run ID: Optimization Goals: ✅ No significant changes detectedFine details of change detection per experiment (5)Experiments configured
Bounds Checks: ✅ Passed (5)
ExplanationA change is flagged as a regression when |Δ mean %| > 5.00% in the regressing direction for its optimization goal AND SMP marks the experiment as a regression ( |
There was a problem hiding this comment.
More details
The sampled provider_kind values are valid Agent configuration values, and the empty branch is omitted so existing timelines retain the default behavior. The change is isolated to Antithesis config generation; no behavioral regression or diff-only production hazard was identified.
🤖 Datadog Autotest · Commit 14ee8b4 · What is Autotest? · @DataDog review to ask questions · Any feedback? Reach out in #autotest
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 14ee8b4347
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
43cf97d to
86e0959
Compare
98dc187 to
aaebc86
Compare
793eced to
2a19b2e
Compare
986783b to
e607b72
Compare
74d04b8 to
fdea3d5
Compare
d06009f to
65092dd
Compare
52ca146 to
9cf8925
Compare
65092dd to
a53d037
Compare
9cf8925 to
686f983
Compare
f3e05f8 to
da6321e
Compare
7e2743b to
0b329dc
Compare
da6321e to
c01556e
Compare
4795d53 to
d9f7f33
Compare
c01556e to
d9441ef
Compare
d9f7f33 to
b7a894e
Compare
f670417 to
9f6682e
Compare
7b80b84 to
f96c13f
Compare
90c9988 to
f207c9c
Compare
57141a5 to
91e00cc
Compare
7e3d076 to
c5e7907
Compare
91e00cc to
335b960
Compare
c5e7907 to
7fc724f
Compare
a07c2b7 to
9d4c44d
Compare
7fc724f to
8d1cf98
Compare
9d4c44d to
2a18400
Compare
8d1cf98 to
5f2c894
Compare
2a18400 to
1fb6bb7
Compare
5f2c894 to
0f55ac4
Compare
Pyld54 asserts a v3 tagset back-reference resolves to an earlier tagset. Agent emits that back-reference only when a metric carries both a shared prefix tagset and its own tags. Previously we only ever emitted load that carried no shared prefix. This commit adds provider_kind into the sampled datadog.yaml. Agent will attach this as a global tag which acts as a shared prefix. 1/3 of configs will not have provider_kind present.
1fb6bb7 to
1d9b68e
Compare
tobz
left a comment
There was a problem hiding this comment.
LGTM.
(Approved in spite of the CI error since that's coming from the ancestor PR.)

Summary
Pyld54 asserts a v3 tagset back-reference resolves to an earlier
tagset. Agent emits that back-reference only when a metric carries both
a shared prefix tagset and its own tags. Previously we only ever emitted
load that carried no shared prefix.
This commit adds provider_kind into the sampled datadog.yaml. Agent will
attach this as a global tag which acts as a shared prefix. 1/3 of
configs will not have provider_kind present.
Change Type
How did you test this PR?
References