Skip to content

perf: single-pass 3MF scan on top of the slice_info size cap #130

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
DLANSAMA merged 2 commits into from
Aug 26, 2026
Merged

perf: single-pass 3MF scan on top of the slice_info size cap #130

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
02c91c0
perf: single-pass 3MF scan and early-exit gcode header parse
DLANSAMA Aug 26, 2026
ef55ea9
style: keep the gcode-member match on one line for ruff format
DLANSAMA Aug 26, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
35 changes: 17 additions & 18 deletions bambu_cli/slicer/estimate.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -89,6 +89,8 @@ def _parse_gcode_header(gcode_bytes: bytes) -> tuple[int | None, float | None]:
grams = v
except (ValueError, TypeError):
pass
if seconds is not None and grams is not None:
break

return seconds, grams

Expand All @@ -106,12 +108,14 @@ def read_3mf_estimate(path: str) -> Estimate:

# Primary: Metadata/slice_info.config
slice_info_name: str | None = None
gcode_members: list[str] = []

for n in names:
normalised = n.replace("\\", "/")
parts = normalised.split("/")
if len(parts) == 2 and parts[0] == "Metadata" and parts[1] == "slice_info.config":
norm = n.replace("\\", "/")
if norm == "Metadata/slice_info.config":
slice_info_name = n
break
elif norm.startswith("Metadata/") and norm.endswith(".gcode") and norm.count("/") == 1:
gcode_members.append(n)

if slice_info_name is not None:
info = zf.getinfo(slice_info_name)
Expand All @@ -131,20 +135,15 @@ def read_3mf_estimate(path: str) -> Estimate:

# Fallback: gcode members under Metadata/, in plate order. Keep
# trying later plates if an earlier one carries no usable header.
gcode_members = sorted(
n
for n in names
if len(n.replace("\\", "/").split("/")) == 2
and n.replace("\\", "/").split("/")[0] == "Metadata"
and n.replace("\\", "/").split("/")[1].endswith(".gcode")
)
for n in gcode_members:
# Read only the header window; a real plate gcode can be tens of MB.
with zf.open(n) as fh:
gcode_bytes = fh.read(GCODE_READ_BYTES)
seconds, grams = _parse_gcode_header(gcode_bytes)
if seconds is not None or grams is not None:
return Estimate(seconds, grams)
if gcode_members:
gcode_members.sort()
for n in gcode_members:
# Read only the header window; a real plate gcode can be tens of MB.
with zf.open(n) as fh:
gcode_bytes = fh.read(GCODE_READ_BYTES)
seconds, grams = _parse_gcode_header(gcode_bytes)
if seconds is not None or grams is not None:
return Estimate(seconds, grams)

except Exception: # noqa: BLE001 — never raise, degrade gracefully
pass
Expand Down
Loading