Skip to content

Split Wolverine discovery and canonical runner code into focused steps - #113

Merged
woksin merged 19 commits into
mainfrom
critterstack-106-part2
Nov 11, 2026
Merged

woksin merged 19 commits into
mainfrom
critterstack-106-part2

Conversation

@woksin

@woksin woksin commented Nov 11, 2026

Copy link
Copy Markdown
Collaborator

Changed

  • Split Wolverine validation, authorization, handler, saga, return consequence, production link and slice pattern discovery into smaller focused methods with no change to generated Screenplay output or diagnostics (part of Code Health: raise all files to 9.5 #106)
  • Split CritterStack source mapping, placement and enum concept detection into smaller focused helpers with no change to generated output (part of Code Health: raise all files to 9.5 #106)
  • Made the canonical runner's expectation checks and parsing table-driven without changing which expectations pass or fail (part of Code Health: raise all files to 9.5 #106)
  • Added characterization specifications that pin the Wolverine discovery results, legacy declaration path mapping, missing source structure diagnostic order and canonical expectation matching (part of Code Health: raise all files to 9.5 #106)

@woksin woksin added the no-release Internal changes that publish no release label Nov 11, 2026
@woksin woksin self-assigned this Nov 11, 2026
@woksin

woksin commented Nov 11, 2026

Copy link
Copy Markdown
Collaborator Author

Reviewer notes for part 2 of the Code Health work in #106 (batches 5 to 8).

  • Behavior-preserving refactors only. Characterization specs pinned each file before it was refactored. C# 15 idioms were adopted only inside files this PR owns, as agreed with the adoption work.
  • Local gate on head 83fe574: Debug and Release builds with --warnaserror (0 warnings), the specification runner self-test, 1642 Release specs with 0 failed, pack plus the package consumer check, canonical verification runs 1 to 8, and dotnet format whitespace, style and analyzers with --verify-no-changes all passed.
  • Each batch got its own review, and the whole change got a review with a security lens. None reported a blocking finding.
  • Code Health went up in ValidationAuthorizationDiscovery (6.49 to 9.68), HandlerDiscovery (7.68 to 10), WolverineSagaFacts (6.62 to 9.68), SlicePatterns (8.60 to 9.68), ReturnConsequences (8.81 to 9.68), ProductionLinks (8.02 to 10), CritterStackSource (8.41 to 9.68), canonical Expectations (7.71 to 9.38), and smaller gains in SagaTypes, Placement and EnumConceptFacts.
  • Still below the issue's 9.5 target: the WolverineFacts partials (9.09 to 9.38), WolverineProductionPlan (9.38), CanonicalRunner (8.45) and canonical Expectations (9.38). Code Health: raise all files to 9.5 #106 stays open for them. Code Health sweeps are paused by a change in priorities, so they are not part of this PR.

@woksin woksin closed this Nov 11, 2026
@woksin woksin reopened this Nov 11, 2026
@woksin
woksin merged commit f58edad into main Nov 11, 2026
@woksin
woksin deleted the critterstack-106-part2 branch November 11, 2026 23:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

no-release Internal changes that publish no release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant