Repository navigation
Code Health: raise all files to 9.5 #106
Description
Follow-up from the .NET 10/11 retargeting (#105). Raise the repository's Code Health to at least 9.5 for every file, and make it pass the whole-solution format check, without changing behavior.
Known gaps
dotnet format Screenplay.CritterStack.slnx --verify-no-changesexits with code 2. These are existing issues, not ones the retargeting introduced.- No per-file Code Health baseline has been taken yet. The only C# file the retargeting changed scores 10.
Acceptance criteria
- A CodeScene baseline lists every file below 9.5, and each of those files is raised to at least 9.5.
-
dotnet format Screenplay.CritterStack.slnx --verify-no-changespasses. - Specs pass, and the Release build has zero warnings.
- No behavior change.
Status
State: Paused — Paused for a change of focus. PRs #110 and #113 are merged. Still below 9.5: the WolverineFacts partials, WolverineProductionPlan, CanonicalRunner (8.45) and the canonical Expectations. Unblock condition: Code Health work is reprioritized for this repository. No technical dependency blocks it.
Branch: dotnet11 (#110, #113)
Scope: Lane D4: planning (design note + two-perspective review) while Generation #90 batches run; branch critterstack-106-code-health
Plan: Batches 5-8 per the accepted plan: characterization specs first on unmodified code, then behaviour-preserving extractions per file with re-score gain >= 0.3, plus C# 15 idioms inside owned files (agreed with the adoption lane). Per-batch Sol review, one whole-change review and whole-solution gate in an L0 slot, then a no-release PR.
Delivered: Nothing yet.
Remaining: To be confirmed.
Follow-ups: None.
Activity
woksin commentedon Nov 10, 2026
Decision for this issue: a Code Health score alone is not a reason to refactor. Before implementing, write a short design note covering the current behavior, a measured baseline, at least two alternative approaches with sources, the chosen approach and what could break. Have that plan reviewed from two perspectives: behavior preservation plus a reviewer on the other model provider. Keep specs green on
mainand on the branch, and bisect any failure before calling it pre-existing. Never move ambient state (AsyncLocal, scopes, transactions, principal, tenant) into async helpers. Drop any refactor that does not measurably improve the code or that makes it harder to understand.