Skip to content

⚡ Bolt: Replace sapply with vapply for performance #104

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
seonghobae wants to merge 1 commit into
base: master
Choose a base branch
from
Open

⚡ Bolt: Replace sapply with vapply for performance #104

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions .jules/bolt.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,3 +15,6 @@
## 2024-05-15 - [R Performance: ifelse Overhead]
**Learning:** In R, ifelse evaluates both true and false branches entirely before subsetting, which is very inefficient for vector operations.
**Action:** Optimize this by preallocating with res <- Y * 0 to preserve attributes and using vectorized subsetting like if any cond res subset <- ...
## 2024-05-14 - Optimize sapply to vapply for performance
**Learning:** In R, `sapply` over a list incurs overhead to deduce the return type. When the return type is known, replacing `sapply` with `vapply(..., FUN.VALUE = numeric(1))` provides a small, safe performance gain.
**Action:** Replace `max(sapply(mispatts, nrow))` with `max(vapply(mispatts, nrow, numeric(1)))` in `R/llcont.R`.
2 changes: 1 addition & 1 deletion R/llcont.R
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -407,7 +407,7 @@ llcont.lavaan <- function(x, ...){
if(tolower(lavInspect(x, "options")$missing) == "ml.x") stop("cannot handle lavaan models with missing='ml.x'. consider using missing='ml'.", call. = FALSE)
mispatts <- lavInspect(x, "patterns")
if(any(class(mispatts) == "list")){
npatts <- max(sapply(mispatts, nrow))
npatts <- max(vapply(mispatts, nrow, numeric(1)))

@devin-ai-integration devin-ai-integration Bot Aug 26, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

📝 Info: vapply type template safe for integer nrow

nrow returns an integer while the vapply template is numeric(1) (double); vapply coerces integer results to double, so no type error occurs and the downstream max() and npatts > 1 check behave as before.

Open in Devin Review

Was this helpful? React with 👍 or 👎 to provide feedback.

} else {
npatts <- nrow(mispatts)
}
Expand Down
Loading