⚡ Bolt: Replace sapply with vapply for performance - #104
Conversation
Replaced `sapply` with `vapply(..., numeric(1))` in `R/llcont.R` when determining the maximum number of rows in missing data patterns. This avoids the overhead of return type deduction in `sapply` when the expected output type is already known.
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
|
Warning Review limit reachedNext included review available in 49 minutes. View limit detailsLimit details: You’ve used the included review currently available. You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Review configuration: ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (2)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
| mispatts <- lavInspect(x, "patterns") | ||
| if(any(class(mispatts) == "list")){ | ||
| npatts <- max(sapply(mispatts, nrow)) | ||
| npatts <- max(vapply(mispatts, nrow, numeric(1))) |
There was a problem hiding this comment.
📝 Info: vapply type template safe for integer nrow
nrow returns an integer while the vapply template is numeric(1) (double); vapply coerces integer results to double, so no type error occurs and the downstream max() and npatts > 1 check behave as before.
Was this helpful? React with 👍 or 👎 to provide feedback.
1 participant
💡 What: Replaced
sapplywithvapply(..., numeric(1))inR/llcont.Rwhen determining the maximum number of rows in missing data patterns.🎯 Why:
sapplyintroduces overhead because it has to evaluate the results and determine the simplified return type dynamically.vapplyallows us to specify the return type (numeric(1)), which avoids this overhead and provides safer type execution.📊 Impact: Small but measurable reduction in execution time for large lists of missing data patterns.
🔬 Measurement: Benchmarking using
microbenchmarkconfirms a performance gain by avoiding type deduction.PR created automatically by Jules for task 2521952499295443931 started by @seonghobae