feat(workspace): name tonight's first overlap on the map

AGENTS.md

@@ -83,6 +83,7 @@ This section applies to any agent (Claude, Codex, Cursor, opencode, ...) working
 - Keep UI and analysis engine decoupled through shared contracts.
 - Prefer minimal, test-first changes for production code.
 - Prefer practical, friendly, rehearsal-first wording over academic or authority-heavy language.
+- Name tonight's first overlap with the warned part when an active role is corroborated, the owned clash text, the labeled section, and the time so the next action is obvious.
 - Do not reduce the product to a chord analyzer when form, timing, player coordination, playable ranges, simplification, and setup cues are the real rehearsal blockers.
 - Do not frame usability as a reason to accept weak analysis quality; BandScope should aim for both easy use and high accuracy.
 

ARCHITECTURE.md

@@ -5,6 +5,7 @@ Last updated: 2026-03-11
 ## Brand source
 
 - Product identity, UX tone, copy rules, and prioritization tie-breakers live in `docs/brand-story.md`.
+- The mounted workspace copy for tonight's first overlap must name the warned part when corroborated, the owned clash text, the labeled section, and the time so the next action is obvious. Open moves to the matching rendered map section. Do not invent a clash from groove, cue, setup, simplification, or range copy.
 - Future PRDs, TRDs, onboarding copy, empty states, error messages, and marketing copy should use that document as the single brand source of truth.
 
 ## Security source

CHANGELOG.md

@@ -6,6 +6,7 @@
 
 - Name tonight's first playable range on the ready rehearsal map and tell the player to check that span on their instrument before the section.
 - Display the analyzed song tempo (BPM) as a badge in the rehearsal workspace.
+- Name tonight's first overlap in the mounted rehearsal workspace so the room can clear the clash together; the Open action moves to the matching rendered map section, while inherited or accessor-backed runtime metadata remains guidance-only instead of becoming navigation authority.
 - 각 합주 역할(Role)별 개인 연습 진행도를 0~100% 범위로 기록 및 시각화할 수 있는 연습 진척도(`practiceProgress`) 트래커 기능 추가. UI 컨트롤(슬라이더 및 +/- 버튼)과 한/영 다국어 지원 포함.
 
 ### Changed

CLAUDE.md

@@ -51,7 +51,7 @@ BandScope is a local-first desktop app for rehearsal prep: it turns a song into
 
 Three layers, decoupled through shared contracts:
 
-- `apps/desktop` — Tauri 2 + Vite + React 19 shell (Tailwind 4, Base UI, Storybook). Feature screens live in `src/features/` (home, workspace, chords, ranges, player, settings). The ready workspace names tonight's first playable range and the next instrument check. `src/lib/analysis.ts` and `src/lib/job_runner.ts` call typed Tauri IPC commands, with a browser fallback that serves demo data when not running inside Tauri.
+- `apps/desktop` — Tauri 2 + Vite + React 19 shell (Tailwind 4, Base UI, Storybook). Feature screens live in `src/features/` (home, workspace, chords, ranges, player, settings). The mounted workspace names tonight's first overlap and opens the matching rendered map section. Do not invent a clash from groove, cue, setup, simplification, or range copy. The ready workspace also names tonight's first playable range and the next instrument check. `src/lib/analysis.ts` and `src/lib/job_runner.ts` call typed Tauri IPC commands, with a browser fallback that serves demo data when not running inside Tauri.
 - `apps/desktop/src-tauri/src/main.rs` — the Rust orchestration boundary. Tauri commands (`start_analysis_job`, `get_analysis_job_status`, `select_local_audio_source`, `import_youtube_url`) validate untrusted input (project IDs, file paths, URLs) and spawn the Python engine as a subprocess. There is no loopback HTTP listener and no network path for local analysis.
 - `services/analysis-engine` — Python package `bandscope_analysis` (librosa/numpy). Entry point `cli.py` reads a JSON job request on stdin and prints a structured job-status JSON envelope on stdout (`--progress-jsonl` streams progress lines). `api.py` orchestrates the pipeline across the `separation`, `sections`, `roles`, `chords`, `ranges`, `temporal`, `transcription`, and `youtube` modules.
 

apps/desktop/src/features/workspace/FirstOverlapCallout.empty-a11y.test.tsx

@@ -0,0 +1,23 @@
+import { render, screen } from "@testing-library/react";
+import { createDemoRehearsalSong } from "@bandscope/shared-types";
+import { describe, expect, it } from "vitest";
+import { FirstOverlapCallout } from "./FirstOverlapCallout";
+
+describe("FirstOverlapCallout empty accessible name", () => {
+  it("keeps the same concise region name while unavailable guidance remains visible", () => {
+    const song = createDemoRehearsalSong();
+    for (const role of song.sections[0]!.roles) {
+      role.overlapWarnings = ["   "];
+    }
+
+    render(<FirstOverlapCallout song={song} />);
+
+    expect(screen.getByLabelText("Tonight's first overlap")).toBeTruthy();
+    expect(
+      screen.getByText("No overlap yet. Stay on tonight's map until a part names a clash.")
+    ).toBeTruthy();
+    expect(
+      screen.queryByLabelText("No overlap yet. Stay on tonight's map until a part names a clash.")
+    ).toBeNull();
+  });
+});

apps/desktop/src/features/workspace/FirstOverlapCallout.particle.test.tsx

@@ -0,0 +1,43 @@
+import { fireEvent, render, screen } from "@testing-library/react";
+import { createDemoRehearsalSong } from "@bandscope/shared-types";
+import { afterEach, describe, expect, it, vi } from "vitest";
+import { FirstOverlapCallout } from "./FirstOverlapCallout";
+
+describe("FirstOverlapCallout Korean role copy", () => {
+  afterEach(() => {
+    vi.unstubAllGlobals();
+  });
+
+  it("keeps vowel-ending dynamic role names particle-safe before and after the overlap action", () => {
+    vi.stubGlobal("navigator", { language: "ko-KR" });
+    const song = createDemoRehearsalSong();
+    const seed = song.sections[0]!;
+    seed.roles = [{ ...seed.roles[0]!, id: "piano", name: "피아노", rehearsalPriority: "high" }];
+    seed.partGraph = [{ role_id: "piano", is_active: true, handoff_to: [], handoff_from: [] }];
+
+    const grid = document.createElement("div");
+    grid.dataset.testid = "song-structure-grid";
+    grid.setAttribute("role", "region");
+    grid.setAttribute("aria-label", "Scrollable song structure timeline");
+    const target = document.createElement("div");
+    target.dataset.sectionIndex = "0";
+    Object.defineProperty(target, "scrollIntoView", {
+      configurable: true,
+      value: vi.fn()
+    });
+    grid.appendChild(target);
+    document.body.appendChild(grid);
+
+    render(<FirstOverlapCallout song={song} />);
+
+    expect(screen.getByText("0:10 벌스에서 피아노 파트가 겹칩니다.")).toBeTruthy();
+    expect(screen.queryByText(/피아노이/)).toBeNull();
+
+    fireEvent.click(screen.getByRole("button", { name: "0:10 피아노 겹침 위치 열기" }));
+
+    expect(screen.getByText("0:10에서 피아노 파트 겹침을 풀으세요. 자리를 나눠 잡으세요.")).toBeTruthy();
+    expect(screen.queryByText(/피아노과/)).toBeNull();
+
+    grid.remove();
+  });
+});

apps/desktop/src/features/workspace/FirstOverlapCallout.progress-persistence.test.tsx

@@ -0,0 +1,63 @@
+import { fireEvent, render, screen } from "@testing-library/react";
+import { createDemoRehearsalSong, type RehearsalSong } from "@bandscope/shared-types";
+import { afterEach, describe, expect, it, vi } from "vitest";
+import { FirstOverlapCallout } from "./FirstOverlapCallout";
+
+let mountedTimeline: HTMLElement | null = null;
+
+function appendSongStructureTarget(): void {
+  const timeline = document.createElement("div");
+  const grid = document.createElement("div");
+  grid.dataset.testid = "song-structure-grid";
+  const target = document.createElement("div");
+  target.dataset.sectionIndex = "0";
+  Object.defineProperty(target, "scrollIntoView", {
+    configurable: true,
+    value: vi.fn()
+  });
+  grid.appendChild(target);
+  timeline.appendChild(grid);
+  document.body.appendChild(timeline);
+  mountedTimeline = timeline;
+}
+
+function withPracticeProgress(song: RehearsalSong, progress: number): RehearsalSong {
+  return {
+    ...song,
+    sections: song.sections.map((section, sectionIndex) =>
+      sectionIndex === 0
+        ? {
+            ...section,
+            roles: section.roles.map((role, roleIndex) =>
+              roleIndex === 0 ? { ...role, practiceProgress: progress } : role
+            )
+          }
+        : section
+    )
+  };
+}
+
+describe("FirstOverlapCallout immutable song updates", () => {
+  afterEach(() => {
+    mountedTimeline?.remove();
+    mountedTimeline = null;
+  });
+
+  it("keeps the opened overlap action armed after unrelated practice progress changes", () => {
+    const song = createDemoRehearsalSong();
+    appendSongStructureTarget();
+    const { rerender } = render(<FirstOverlapCallout song={song} />);
+
+    fireEvent.click(screen.getByRole("button", { name: "Open Bass Guitar overlap at 0:10" }));
+    expect(
+      screen.getByText(/Clear the overlap with Bass Guitar at 0:10. Make room for each other./)
+    ).toBeTruthy();
+
+    rerender(<FirstOverlapCallout song={withPracticeProgress(song, 42)} />);
+
+    expect(
+      screen.getByText(/Clear the overlap with Bass Guitar at 0:10. Make room for each other./)
+    ).toBeTruthy();
+    expect(screen.queryByText("Bass Guitar overlaps in the verse at 0:10.")).toBeNull();
+  });
+});

apps/desktop/src/features/workspace/FirstOverlapCallout.reduced-motion.test.tsx

@@ -0,0 +1,43 @@
+import { fireEvent, render, screen } from "@testing-library/react";
+import { createDemoRehearsalSong } from "@bandscope/shared-types";
+import { afterEach, describe, expect, it, vi } from "vitest";
+import { FirstOverlapCallout } from "./FirstOverlapCallout";
+
+describe("FirstOverlapCallout reduced motion", () => {
+  afterEach(() => {
+    vi.unstubAllGlobals();
+  });
+
+  it("scrolls immediately when the operating system requests reduced motion", () => {
+    vi.stubGlobal("matchMedia", (query: string) => ({
+      matches: query === "(prefers-reduced-motion: reduce)",
+      media: query,
+      onchange: null,
+      addListener: vi.fn(),
+      removeListener: vi.fn(),
+      addEventListener: vi.fn(),
+      removeEventListener: vi.fn(),
+      dispatchEvent: vi.fn()
+    }));
+
+    const grid = document.createElement("div");
+    grid.dataset.testid = "song-structure-grid";
+    grid.setAttribute("role", "region");
+    grid.setAttribute("aria-label", "Scrollable song structure timeline");
+    const target = document.createElement("div");
+    target.dataset.sectionIndex = "0";
+    const scrollIntoView = vi.fn();
+    Object.defineProperty(target, "scrollIntoView", {
+      configurable: true,
+      value: scrollIntoView
+    });
+    grid.appendChild(target);
+    document.body.appendChild(grid);
+
+    render(<FirstOverlapCallout song={createDemoRehearsalSong()} />);
+    fireEvent.click(screen.getByRole("button", { name: "Open Bass Guitar overlap at 0:10" }));
+    expect(scrollIntoView).toHaveBeenCalledWith({ block: "nearest", behavior: "auto" });
+
+    grid.remove();
+  });
+});