feat(player): play real audio section loops - #1062
Conversation
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Current-head verification after the review fixes:
|
What changed
timeupdateplayhead synchttp://asset.localhostmedia origin alongside macOSasset:without broadening other CSP directivesExact current identity
feat/rehearsal-player-first-section-loop@7a59047b004faa7a0b584f3d6d68c94889a452d5(PR feat(workspace): loop tonight's first section from the map #971)2ff261585b2e4cf78100be92785ff91fe373c0b2developCurrent-head repair evidence
asset:and exacthttp://asset.localhostwhile rejecting broadhttp:/https:media sources.5187e038bb6ae0918d972a26fe4e3f3b594387ebalso caps the timeout at2_147_483_647ms.6a9c576112de977e824f41eb168504e4139ddc0dproveshasLocalAudio=trueplus an unusablebrowser://source must not enable the Start control or honor an external start nonce. Repair2ff261585b2e4cf78100be92785ff91fe373c0b2derives authority from both validated local-audio state and a successfully resolved scoped asset URL, stops transport when that authority disappears, and removes the no-source pseudo-clock fallback from this real-audio slice.Security Notes
scope: []; only a canonical file selected by the native dialog or validated inside the app-owned YouTube cache is added at runtime.browser://, absent, or conversion-failed source paths cannot start or sustain transport even when stale local-audio metadata remains true.Verification boundary
The new exact head currently has no hosted check-run/workflow evidence materialized on this stacked non-default-base PR, so predecessor/local evidence is not being promoted to exact-head GREEN. Revalidate this head after deliberate restack/integration into the protected delivery chain; do not merge or transfer prior-head review/check evidence.
This remains a stacked follow-up to #971 and must be reviewed against the exact base/head above.