-
Notifications
You must be signed in to change notification settings - Fork 0
feat(workspace): name tonight's first articulation plan on the map #1012
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
seonghobae
wants to merge
14
commits into
develop
Choose a base branch
from
feat/workspace-first-articulation-plan
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
14 commits
Select commit
Hold shift + click to select a range
a7057c0
feat(workspace): name tonight's first articulation plan on the map
seonghobae 48ff145
test(workspace): require neutral articulation fallback copy
seonghobae 4411096
fix(workspace): neutralize articulation unavailable copy
seonghobae 22883a8
fix(workspace): localize neutral articulation fallback
seonghobae aeee17b
docs(i18n): describe translator fallback contract
seonghobae ac087d0
test(workspace): align articulation fallback assertions
seonghobae 7b1ad37
test(workspace): reject non-contract articulation labels
seonghobae 039b68c
fix(workspace): reject non-contract articulation labels
seonghobae ac3697d
test(workspace): require articulation plan coverage ownership
seonghobae 4d87fe5
fix(coverage): include articulation production paths
seonghobae 581e6c9
Merge branch 'develop' into feat/workspace-first-articulation-plan
seonghobae 4a49f36
Merge remote-tracking branch 'origin/develop' into HEAD
seonghobae e632b16
test(articulation): cover non-reduced motion and placeholder fallback
seonghobae 25d777f
docs(palette): drop role=button from disabled-button wrapper example
seonghobae File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file was deleted.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,3 +1,43 @@ | ||
| ## 2024-05-19 - Replace HTML disabled with aria-disabled="true" for Accessible Tooltips | ||
| **Learning:** Native HTML `disabled` attributes completely hide elements from screen readers and block all pointer/hover events, preventing tooltips from functioning for disabled elements. | ||
| **Action:** Replace `disabled` with `aria-disabled="true"`, enforce block click handlers via `e.preventDefault()`, and add a title tooltip directly to the element to maintain full tooltip accessibility and keyboard focus support for visually impaired and mouse users. | ||
|
|
||
| ## 2024-05-18 - Added focus visible styles for keyboard navigation | ||
| **Learning:** Interactive inline buttons (like the chord editor) and scrollable regions with `tabIndex={0}` do not automatically get focus visible styles, meaning keyboard users tabbing through won't know they are focused on them. Unlike central `<Button />` components which bake focus states in, these custom inline interactive elements need explicit focus styling. | ||
| **Action:** Always add explicit focus visible styles (e.g., `focus-visible:outline-none focus-visible:ring-2 focus-visible:ring-cyan-300`) to custom interactive elements and scrollable regions with `tabIndex={0}` for proper keyboard accessibility. | ||
|
|
||
| ## 2024-05-24 - Visual tooltips for disabled icon-only buttons | ||
| **Learning:** Icon-only buttons with `aria-label` are accessible to screen readers, but sighted users relying on mouse hover don't get context if the `title` attribute is missing, especially when the button is disabled and its purpose is unclear (e.g. "coming soon"). | ||
| **Action:** Always add a `title` attribute mirroring the `aria-label` (or providing a specific disabled reason) to icon-only buttons so sighted users also receive explanatory tooltips on hover. | ||
|
|
||
| ## 2026-06-13 - Added screen reader text for tooltip divs | ||
| **Learning:** When using `title` attributes on non-interactive elements like icon-only `div`s for tooltips, screen readers might not announce them properly because they aren't focusable. The visual tooltip is not enough for accessibility. | ||
| **Action:** Always add a visually hidden `<span className="sr-only">[Tooltip Text]</span>` inside non-interactive elements that rely on a `title` attribute so that screen readers have text content to announce. | ||
|
|
||
| ## 2026-06-18 - Added keyboard accessibility to scrollable regions | ||
| **Learning:** Horizontally scrollable regions (like the `SectionRoadmap` component) are not accessible to keyboard-only users unless they can receive focus. Keyboard users must be able to focus the container to scroll its content using arrow keys. | ||
| **Action:** For proper keyboard accessibility in custom scrollable regions, always include `tabIndex={0}`, an appropriate `aria-label`, `role="region"`, and explicit focus visible styling (e.g., `focus-visible:outline-none focus-visible:ring-2 focus-visible:ring-cyan-300`). | ||
|
|
||
| ## 2026-06-19 - Internationalization | ||
| **Learning:** The desktop app uses i18n via json files located in `apps/desktop/src/locales/` | ||
| **Action:** When adding new text strings, make sure to add it to all locale files. | ||
|
|
||
| ## 2026-06-25 - Native tooltips on disabled elements | ||
| **Learning:** Standard HTML `title` attributes used as tooltips do not render on elements that use Tailwind's `pointer-events-none` class, which is often applied to `disabled:` variants in Base UI and styled components. | ||
| **Action:** Do not rely on native `title` attributes for explaining disabled states on buttons with `pointer-events-none`. Instead, either use a custom tooltip component or ensure focus/interactive styles are preserved if an explanation is strictly required. | ||
|
|
||
| ## 2024-06-29 - 비활성화된 네이티브 버튼의 툴팁 차단 | ||
| **Learning:** 네이티브 `<button>` 요소에 `disabled` 속성을 사용하면 마우스 호버 이벤트를 포함한 포인터 이벤트가 완전히 차단되어 표준 HTML `title` 속성이 툴팁으로 표시되지 않으며, 키보드 탭 순서(tab order)에서도 제외됩니다. | ||
| **Action:** "출시 예정" 등 설명 툴팁이 필요한 비활성화된 액션 버튼의 경우, `title`을 버튼에 직접 붙이는 대신 포커스 가능한 `span` (`<span tabIndex={0} title={...} aria-disabled="true">`)으로 버튼을 감싸서 시각적 및 스크린 리더 접근성을 모두 보장해야 합니다. | ||
|
|
||
| ## 2024-07-01 - Testing components with focusable disabled button wrappers | ||
| **Learning:** When native disabled buttons are wrapped in a focusable `span` to provide accessible tooltips, tests that previously found and clicked the `button` (by temporarily removing the `disabled` attribute) may fail or become overly complex. It is cleaner and more accurate to query the wrapper element (e.g. via its `title`) and fire events on it, reflecting the actual accessible DOM structure. | ||
| **Action:** When testing UI components that wrap disabled buttons in a focusable span for accessibility (e.g., using a tooltip/title), use `screen.getByTitle(...)` to query the wrapper element for interactions like `fireEvent.click` rather than `screen.getByRole('button')`. | ||
|
|
||
| ## 2024-05-24 - Avoid nesting native buttons with ARIA role button on wrappers | ||
| **Learning:** Adding `role="button"` to a `span` or `div` wrapper that contains a native `<button>` element inside violates ARIA specifications. Interactive roles (like `button`) must not contain other interactive elements (even if the inner element is disabled or has `aria-hidden`), as this causes invalid/redundant accessibility trees and screen reader confusion. | ||
| **Action:** Always verify wrappers used to implement tooltips for disabled buttons are standard elements (e.g., `<span tabIndex={0} title="...">`) but *do not* assign `role="button"` to the wrapper itself. | ||
|
|
||
| ## 2026-07-02 - Inline clear buttons preserve focus | ||
| **Learning:** Inline clear buttons often unmount immediately after clearing state, which can drop keyboard focus to the document body. | ||
| **Action:** Move focus back to the owning input before clearing state, and cover the behavior with a DOM focus test. | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
21 changes: 21 additions & 0 deletions
21
apps/desktop/src/features/workspace/FirstArticulationPlanCallout.identity.test.tsx
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,21 @@ | ||
| import { render, screen } from "@testing-library/react"; | ||
| import { createDemoRehearsalSong } from "@bandscope/shared-types"; | ||
| import { expect, it } from "vitest"; | ||
| import { FirstArticulationPlanCallout } from "./FirstArticulationPlanCallout"; | ||
|
|
||
| it("gives co-mounted articulation-plan callouts distinct DOM identities", () => { | ||
| render( | ||
| <> | ||
| <FirstArticulationPlanCallout song={createDemoRehearsalSong()} /> | ||
| <FirstArticulationPlanCallout song={createDemoRehearsalSong()} /> | ||
| </> | ||
| ); | ||
|
|
||
| const callouts = screen.getAllByRole("complementary", { | ||
| name: "Tonight's first articulation plan" | ||
| }); | ||
| const ids = callouts.map((callout) => callout.id); | ||
|
|
||
| expect(ids.every((id) => id.length > 0)).toBe(true); | ||
| expect(new Set(ids).size).toBe(callouts.length); | ||
| }); |
52 changes: 52 additions & 0 deletions
52
apps/desktop/src/features/workspace/FirstArticulationPlanCallout.particle.test.tsx
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,52 @@ | ||
| import { fireEvent, render, screen } from "@testing-library/react"; | ||
| import { createDemoRehearsalSong } from "@bandscope/shared-types"; | ||
| import { afterEach, describe, expect, it, vi } from "vitest"; | ||
| import { FirstArticulationPlanCallout } from "./FirstArticulationPlanCallout"; | ||
|
|
||
| describe("FirstArticulationPlanCallout Korean role copy", () => { | ||
| afterEach(() => { | ||
| vi.unstubAllGlobals(); | ||
| }); | ||
|
|
||
| it("keeps vowel-ending role names particle-safe before and after the articulation action", () => { | ||
| vi.stubGlobal("navigator", { language: "ko-KR" }); | ||
| const song = createDemoRehearsalSong(); | ||
| const seed = song.sections[0]!; | ||
| seed.roles = [ | ||
| { | ||
| ...seed.roles[0]!, | ||
| id: "piano", | ||
| name: "피아노", | ||
| rehearsalPriority: "high", | ||
| articulationPlan: "Keep the verse attack short so the chorus still has a longer sustain to land on." | ||
| } | ||
| ]; | ||
| seed.partGraph = [{ role_id: "piano", is_active: true, handoff_to: [], handoff_from: [] }]; | ||
|
|
||
| const grid = document.createElement("div"); | ||
| grid.dataset.testid = "song-structure-grid"; | ||
| grid.setAttribute("role", "region"); | ||
| grid.setAttribute("aria-label", "Scrollable song structure timeline"); | ||
| const target = document.createElement("div"); | ||
| target.dataset.sectionIndex = "0"; | ||
| Object.defineProperty(target, "scrollIntoView", { | ||
| configurable: true, | ||
| value: vi.fn() | ||
| }); | ||
| grid.appendChild(target); | ||
| document.body.appendChild(grid); | ||
|
|
||
| render(<FirstArticulationPlanCallout song={song} />); | ||
|
|
||
| expect(screen.getByText("0:10 벌스에서 피아노 파트의 아티큘레이션 계획이 있습니다.")).toBeTruthy(); | ||
| expect(screen.queryByText(/피아노이/)).toBeNull(); | ||
| expect(screen.queryByText(/피아노가/)).toBeNull(); | ||
|
|
||
| fireEvent.click(screen.getByRole("button", { name: "0:10 피아노 아티큘레이션 열기" })); | ||
|
|
||
| expect(screen.getByText("0:10에서 피아노 파트의 아티큘레이션을 맞춘 다음 합주를 시작하세요.")).toBeTruthy(); | ||
| expect(screen.queryByText(/피아노과/)).toBeNull(); | ||
|
|
||
| grid.remove(); | ||
| }); | ||
| }); |
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.