feat(workspace): name tonight's first articulation plan on the map - #1012
feat(workspace): name tonight's first articulation plan on the map#1012seonghobae wants to merge 14 commits into
Conversation
After analysis, the room can open the first owned articulation plan on the rehearsal map instead of inferring attack or sustain from groove, setup notes, or dynamics copy.
|
Warning Review limit reachedNext included review available in 55 minutes. View limit detailsLimit details: You’ve used the included review currently available. You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Review configuration: ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthrough리허설 역할에 Changes첫 articulation plan 기능
Estimated code review effort: 4 (Complex) | ~45 minutes Merge Risk: 🔵 Low · up to The PR adds an articulation-plan callout and map navigation, but a fallback message can direct users to a selected part when none is selected. This is a localized user-facing issue, so the change is mergeable with explicit owner awareness and follow-up. Sequence Diagram(s)sequenceDiagram
participant Workspace
participant FirstArticulationPlanCallout
participant resolveFirstArticulationPlan
participant SongStructure
Workspace->>FirstArticulationPlanCallout: song 전달
FirstArticulationPlanCallout->>resolveFirstArticulationPlan: 첫 계획 해석 요청
resolveFirstArticulationPlan-->>FirstArticulationPlanCallout: 계획, 역할, 섹션, 시간 반환
FirstArticulationPlanCallout->>SongStructure: 섹션 인덱스 대상 조회
SongStructure-->>FirstArticulationPlanCallout: scrollIntoView 실행
FirstArticulationPlanCallout-->>Workspace: armed 안내 표시
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
Full details: Docstring CoverageExplanation Docstring coverage is 88.89% which is sufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 27 functions across 12 files. (7 skipped: 7 unsupported.) ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Re-review request for exact head |
# Conflicts: # AGENTS.md # CHANGELOG.md # CLAUDE.md # apps/desktop/src/features/workspace/Workspace.tsx # apps/desktop/src/locales/en/common.json # apps/desktop/src/locales/ko/common.json
|
Resolved merge conflicts against origin/develop (749511c): union-merged AGENTS.md/CHANGELOG.md bullets, sentence-merged CLAUDE.md, kept both import sets in Workspace.tsx (FirstArticulationPlanCallout + firstRangeSqueeze), unioned en/ko locale tails (JSON valid, en/ko symmetric). Merged legacy .Jules/palette.md into canonical .jules/palette.md, dropped alias. No conflict markers remain. Merge head: 4a49f36. |
Devin flagged two branches with no test coverage that sit under the 90% gate: matchMedia-present-but-not-reduced (smooth scroll) and the values[key] ?? placeholder fallback in formatArticulationPlanCopy. - export formatArticulationPlanCopy (mirrors fillRangeCopy precedent) - add smooth-scroll case to the reduced-motion suite - add copy-format unit tests incl. missing-value placeholder passthrough Evidence: Callout suite 14/14, motion 2/2, copy-format 3/3, resolver 18/18 (34 total across the touched files).
Aligns the tooltip-wrapper guidance with the later rule forbidding interactive roles on wrappers that contain native buttons.
Product outcome
After analysis, the room can see tonight's first owned articulation plan and take one next action: open that part on the map.
Cites
docs/design-system/component-contract.md(First Articulation Plan Callout).This is a setup-cue next action after first-setup-note, first-transposition-plan, first-tuning-plan, and first-dynamics-plan. It is not a parallel MIR product and does not invent articulation from groove, cue, simplification, overlap, range, chords, function labels, setup notes, transposition plans, tuning plans, dynamics plans, confirmed overrides, harmonic explanations, or confidence notes.
Exact current identity
develop@acdbea6344fe1231c39535b575f4de35e4c607c9.feat/workspace-first-articulation-plan.a7057c0ac2fb5dac5929a039d3f00196721df06c.Buyer-facing copy
{role} still has an articulation plan in the {section} at {at}plus the ownedarticulationPlantext.Open {role} articulation at {at}scrolls the renderer-owned[data-testid=song-structure-grid] [data-section-index=N].Lock that articulation on {role} at {at} before the room starts.Korean copy stays particle-safe with
파트.Safety
scroll-behavior: auto.Out of scope
Summary by CodeRabbit
새 기능
문서
테스트