feat(workspace): name tonight's first part handoff on the map - #1007
feat(workspace): name tonight's first part handoff on the map#1007seonghobae wants to merge 7 commits into
Conversation
|
Warning Review limit reachedNext included review available in 25 minutes. View limit detailsLimit details: You’ve used the included review currently available. You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Review configuration: ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (22)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
The aside used a fixed id, so two mounted callouts would emit duplicate DOM ids. Follow the sibling FirstHarmonicFunctionCallout pattern and suffix the id with React useId(); nothing anchors to the bare id externally.
# Conflicts: # AGENTS.md # CHANGELOG.md # CLAUDE.md # apps/desktop/src/locales/en/common.json # apps/desktop/src/locales/ko/common.json
|
Resolved merge conflicts against origin/develop (749511c): union-merged AGENTS.md/CHANGELOG.md bullets, sentence-merged CLAUDE.md, unioned en/ko locale tails (JSON valid, en/ko symmetric). Workspace.tsx auto-merged with FirstPartHandoffCallout intact (import + render verified). Merged legacy .Jules/palette.md into canonical .jules/palette.md, dropped alias. No conflict markers remain. Merge head: 679e518. |
Product outcome
Name tonight's first corroborated part-to-part handoff on the mounted rehearsal map so the room can lock the owned pass before rehearsal. Open is the next action: it moves to the matching rendered song-structure section.
Demo: Bass Guitar still hands off to Lead Vocal in the verse at 0:10. Korean copy stays particle-safe (
{from} 파트가 {to} 파트로).This map next-action is distinct from:
handoffform guidance (feat(workspace): guide tonight's first labeled handoff on map and player #937)Do not mix with #811, #828, or #897.
Exact current identity
develop@acdbea6344fe1231c39535b575f4de35e4c607c9.feat/workspace-first-part-handoff.87664d8fd1c7a111964faa48f9bfd1b65d233446.Current implementation
handoff_to/handoff_fromedges.handoff_from.FirstPartHandoffCalloutOpen scrolls the renderer-owneddata-section-indextarget. Analysissection.idis never DOM-ID authority.behavior: "auto"; otherwisesmooth.handoffform without owned bidirectional graph edges.Security Notes
partGraphedges, identity accessors) plus DOM navigation against the mounted song-structure renderer.nulland keep the callout guidance-only.Dependency / merge gate
pdfjs-dist/nanoid/undiciHIGH findings are not copied or suppressed here. No lockfile change.