feat(workspace): name tonight's first capo plan on the map - #1008
feat(workspace): name tonight's first capo plan on the map#1008seonghobae wants to merge 7 commits into
Conversation
Name the earliest corroborated guitar capo plan so the room can lock the owned capo and tuning before rehearsal. Open scrolls the renderer-owned song-structure section. Distinct from first-setup-note (#1004) and first-transposition-plan (#1006). Do not invent that copy from groove, cue, simplification, overlap, range, chord labels, function labels, setup notes, transposition plans, confirmed overrides, harmonic explanations, or confidence notes.
|
Warning Review limit reachedNext included review available in 24 minutes. View limit detailsLimit details: You’ve used the included review currently available. You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Review configuration: ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (25)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Re-review request for exact head |
# Conflicts: # AGENTS.md # CHANGELOG.md # CLAUDE.md # apps/desktop/src/features/workspace/Workspace.tsx # apps/desktop/src/locales/en/common.json # apps/desktop/src/locales/ko/common.json
|
Resolved merge conflicts against origin/develop (749511c): union-merged AGENTS.md/CHANGELOG.md bullets, sentence-merged CLAUDE.md, kept both import sets in Workspace.tsx (FirstCapoPlanCallout + firstRangeSqueeze), unioned en/ko locale tails (JSON valid, en/ko symmetric). Merged legacy .Jules/palette.md into canonical .jules/palette.md, dropped alias. No conflict markers remain. Merge head: 5cd43ff. |
Buyer next action
The mounted rehearsal workspace now names tonight's first capo plan so a guitar part can lock the owned capo and tuning before rehearsal starts.
Demo: Acoustic Guitar still has Capo 2 in standard tuning so the verse fingers G shapes while the room still sounds in A. Open is the next action: it moves to the matching rendered song-structure section.
Protected base:
develop@acdbea6344fe1231c39535b575f4de35e4c607c9.Exact current head:
55646c2453cb559ce5a0ef3cee77c2e6746f9df1onfeat/workspace-first-capo-plan.What the player sees
capoPlancopy, the labeled section, and the time.Authority boundary
harmonicExplanation, or confidence notes.RehearsalRole.capoPlanis distinct fromsetupNoteandtranspositionPlan. The engine still may dump capo intosetupNote; this workspace next action never parses that field.section.idis never DOM-ID authority. Open uses renderer-owneddata-section-index.Docs
AGENTS.md, CLAUDE.md, ARCHITECTURE.md, CHANGELOG.md, and
docs/design-system/component-contract.mdname this next action. Reduced-motion Open usesbehavior: "auto".Security Notes
partGraph, identity accessors) plus DOM navigation against the mounted song-structure renderer.nulland keep the callout guidance-only.Dependency / merge gate
pdfjs-dist/nanoid/undiciHIGH findings are not copied or suppressed here. No lockfile change.