feat(workspace): name tonight's first transposition plan on the map

[seonghobae]

Buyer next action

The mounted rehearsal workspace names tonight's first transposition plan so the room can lock the owned part transpose before rehearsal starts.

Protected base: develop@7ad56cf0065d068ec6463d92726de4855a6e201d.
Exact current head: 54db8d4dcf6183c421713873d2c2082419d6ebc6 on feat/workspace-first-transposition-plan.

What the player sees

• The callout names the owning part when an active graph node corroborates it, the owned transpositionPlan copy, the labeled section, and the time.
• Open scrolls the renderer-owned song-structure section and arms the next action: lock that transpose before the room starts.
• If no part owns transpose copy, the card stays guidance-only and keeps the user on tonight's map.
• The complementary region keeps the stable accessible name Tonight's first transpose plan in both ready and unavailable states; the longer unavailable guidance remains visible body copy rather than replacing landmark identity.

Authority boundary

• Do not invent that copy from groove, cue, simplification, overlap, range, chord labels, function labels, setup notes, confirmed overrides, harmonicExplanation, or confidence notes.
• Inherited or accessor-backed runtime metadata remains guidance-only instead of becoming navigation authority.
• Analysis section.id is never DOM-ID authority.
• Distinct from first-entrance Tempo/Key/Transpose cockpit metrics (feat(workspace): name tonight's tempo, starting chord, and transpose setup #987), first-setup-note (feat(workspace): name tonight's first setup note on the map #1004), first-harmonic-function (feat(workspace): name tonight's first harmonic function on the map #1005), first-harmonic-explanation (feat(workspace): name tonight's first harmonic explanation on the map #1003), and first-confirmed-harmony (feat(workspace): name tonight's first confirmed chord on the map #1002).

Current reliability and accessibility repairs

• The ready and unavailable states share the concise firstTranspositionPlanLabel landmark name while keeping unavailable guidance as visible body copy.
• Section labels and the rehearsal-priorities focus prefix are localized consistently across the timeline, roadmap, and Korean focus line.
• Test navigation fixtures are now removed from document.body in afterEach, including decoy roots, so an early failed assertion cannot leak a renderer into later fail-closed tests.
• The section-label regression first proves the demo section resolves before mutating the runtime label outside SectionFormLabel.
• The resolver test helper reuses shared SectionFormLabel and RehearsalPriority types instead of redeclaring parallel unions.
• The workspace-scope regression now reopens after section reordering and proves the moved plan scrolls renderer index 1.

Docs

AGENTS.md, CLAUDE.md, ARCHITECTURE.md, CHANGELOG.md, and docs/design-system/component-contract.md name this next action. With no mapped Figma node, this feature-local callout remains in the documented Pattern Backlog rather than pretending to be a canonical Figma component. Reduced-motion Open uses behavior: "auto".

Verification / merge gate

• fix(security): establish canonical npm, PDF.js, Nanoid, and Undici baseline #783 is now protected shipped truth in the current develop@7ad56cf0065d068ec6463d92726de4855a6e201d; this PR does not duplicate that dependency-security authority.
• Fresh repository workflows were dispatched for exact head 54db8d4dcf6183c421713873d2c2082419d6ebc6. At the latest refetch CI, release, build-baseline, SBOM, security-audit, aggregate Security Scan, Bandit, Semgrep, and secret-scan were queued or pending, so none is counted as current-head success yet.
• Keep unmerged until the unchanged then-current head has every applicable repository/central CI, cross-platform build, exact owned statement+branch coverage, docstring, SAST/security/SBOM/supply-chain/package/release gate terminal-success; zero valid unresolved findings; a qualifying independent non-author last-push approval; and ordinary branch-protection acceptance.
• Queued, pending, skipped, cancelled, failed, predecessor-head, protected-base, model-only, self/author, neutral, rate-limited, or administrative-bypass evidence is not success.
• Never bypass protection or transfer predecessor evidence.

---

[coderabbitai]

Warning

Review limit reached

Next included review available in 5 minutes.

View limit details

Limit details: You’ve used the included review currently available.

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Learn how review limits work.

Review configuration:

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: eadbe3d8-a80d-4e7d-8233-b0265b98e8ec

📥 Commits

Reviewing files that changed from the base of the PR and between 0d5dba7 and 6f351b0.

📒 Files selected for processing (18)

• .Jules/palette.md
• .jules/palette.md
• AGENTS.md
• ARCHITECTURE.md
• CHANGELOG.md
• CLAUDE.md
• apps/desktop/src/features/workspace/FirstTranspositionPlanCallout.accessibility.test.tsx
• apps/desktop/src/features/workspace/FirstTranspositionPlanCallout.test.tsx
• apps/desktop/src/features/workspace/FirstTranspositionPlanCallout.workspace-scope.test.tsx
• apps/desktop/src/features/workspace/SectionRoadmap.test.tsx
• apps/desktop/src/features/workspace/SectionRoadmap.tsx
• apps/desktop/src/features/workspace/Workspace.test.tsx
• apps/desktop/src/features/workspace/Workspace.tsx
• apps/desktop/src/features/workspace/firstTranspositionPlan.section-label.test.ts
• apps/desktop/src/features/workspace/firstTranspositionPlan.test.ts
• apps/desktop/src/locales/en/common.json
• apps/desktop/src/locales/ko/common.json
• docs/design-system/component-contract.md

📝 Walkthrough

Walkthrough

리허설 작업공간이 첫 번째 이조 계획을 안전하게 선택하고 표시합니다. 사용자는 대응하는 렌더러 섹션으로 이동할 수 있습니다. 섹션 라벨, focus 문구, 안내 문구가 영어와 한국어로 현지화됩니다. 접근성 및 reduced-motion 동작을 테스트했습니다.

Changes

첫 번째 이조 계획 작업공간 흐름

Layer / File(s)	Summary
이조 계획 해석과 입력 검증 apps/desktop/src/features/workspace/firstTranspositionPlan.ts, apps/desktop/src/features/workspace/firstTranspositionPlan*.test.ts	신뢰할 수 있는 소유 데이터와 활성 그래프 노드만 검사합니다. 우선순위, 시작 시간, 안정적인 ID로 첫 계획을 선택합니다. 잘못된 런타임 구조, 중복 ID, 잘못된 시간, 긴 문자열은 거부하거나 제한합니다.
섹션 라벨과 안내 문구 국제화 apps/desktop/src/i18n/*, apps/desktop/src/locales/*/common.json, apps/desktop/src/features/workspace/SectionRoadmap.*, apps/desktop/src/features/workspace/Workspace.tsx, apps/desktop/src/features/workspace/Workspace.section-label-localization.test.tsx, apps/desktop/src/features/workspace/Workspace.test.tsx	섹션 형식 라벨과 rehearsal focus 문구를 로케일에 맞게 표시합니다. 첫 번째 이조 계획 안내 문구를 영어와 한국어 리소스에 추가합니다.
작업공간 안내와 섹션 탐색 apps/desktop/src/features/workspace/FirstTranspositionPlanCallout.tsx, apps/desktop/src/features/workspace/FirstTranspositionPlanCallout*.test.tsx, apps/desktop/src/features/workspace/Workspace.tsx, apps/desktop/src/features/workspace/Workspace.test.tsx	계획을 표시하고 Open 동작으로 renderer 소유 섹션을 탐색합니다. 계획 또는 곡이 변경되면 상태를 초기화합니다. 대상 섹션이 없으면 완료 안내를 표시하지 않습니다. reduced-motion 환경에서는 즉시 스크롤합니다.
기능 계약과 운영 문서 AGENTS.md, ARCHITECTURE.md, CHANGELOG.md, CLAUDE.md, docs/design-system/component-contract.md, docs/doctoring/reduced-motion-first-transposition-plan-navigation.md	계획 문구의 허용된 데이터 출처, 섹션 연결 방식, 탐색 동작, reduced-motion 동작을 문서화합니다.

Estimated code review effort: 4 (Complex) | ~45 minutes

Merge Risk: 🔵 Low · up to 0d5db

The workspace now surfaces and opens the first transpose plan, but Korean users may see a mixed-language focus label and the unavailable English guidance is unclear and implementation-oriented. The PR is mergeable with explicit owner follow-up on these bounded presentation issues.

Sequence Diagram(s)

sequenceDiagram
  participant Workspace
  participant FirstTranspositionPlanCallout
  participant resolveFirstTranspositionPlan
  participant SongStructureRenderer
  participant SectionElement
  Workspace->>FirstTranspositionPlanCallout: 곡 데이터 전달
  FirstTranspositionPlanCallout->>resolveFirstTranspositionPlan: 첫 번째 이조 계획 해석
  resolveFirstTranspositionPlan-->>FirstTranspositionPlanCallout: 계획 정보 반환
  FirstTranspositionPlanCallout->>SongStructureRenderer: 대상 renderer 확인
  FirstTranspositionPlanCallout->>SectionElement: 대응 섹션 조회
  FirstTranspositionPlanCallout->>SectionElement: scrollIntoView 호출
  SectionElement-->>FirstTranspositionPlanCallout: 열린 계획 상태 갱신

Loading

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Docstring Coverage	✅ Passed	Docstring coverage is 84.85% which is sufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 33 functions across 17 files. (8 skipped: 8…
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	제목은 mounted rehearsal workspace에서 첫 번째 transposition plan의 이름을 표시하고 map의 해당 섹션으로 이동하는 주요 변경을 정확하고 간결하게 요약합니다.

Full details: Docstring Coverage

Explanation

Docstring coverage is 84.85% which is sufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 33 functions across 17 files. (8 skipped: 8 unsupported.)

✨ Finishing Touches

📝 Generate docstrings

• Create stacked PR
• Commit on current branch

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch feat/workspace-first-transposition-plan

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[seonghobae]

@opencode-agent Continue the existing feat/workspace-first-transposition-plan branch from exact head cb2dbaa1303def6c170552d8f9de6cccc2532e12 only. Refetch head/base/blob/reviews immediately before writing; if the branch moved, inspect the intervening delta and adapt instead of overwriting it. Do not create another branch/PR.

I have already committed the regression first at cb2dbaa...: apps/desktop/src/features/workspace/Workspace.section-label-localization.test.tsx requires the Korean song-structure grid to render the canonical verse form as 벌스 and not raw verse. The current production Workspace.tsx::SongStructure still renders {section.label} raw, while FirstTranspositionPlanCallout uses translateSectionFormLabel(locale, named.section.label). This is the verified cause of current review thread PRRT_kwDORjvEXs6bkhoq and creates contradictory Korean map/callout copy.

Use TDD from the committed RED and make the narrowest production fix in Workspace.tsx: resolve detectPreferredLocale() once for the Workspace render, build createTranslator(locale) from that same locale, pass the same locale to SongStructure, and render translateSectionFormLabel(locale, section.label) instead of raw section.label. Keep renderer-owned data-section-index, section ordering, timing, groove, IDs, navigation and all unrelated Workspace behavior unchanged. Prefer ReturnType<typeof detectPreferredLocale> if a prop type is needed rather than inventing a new locale authority. Do not translate arbitrary free-form groove text.

Verification: run the new focused test plus existing Workspace/transposition/i18n tests, desktop typecheck/Vitest with configured 100% owned coverage, then current-head CI/release/build/SAST/SBOM/security gates. Resolve only PRRT_kwDORjvEXs6bkhoq after fixed-head evidence. Inherited npm HIGH failures remain canonical #783-owned; do not suppress or leaf-remediate them here.

[opencode-agent]

Queued @opencode-agent for PR #1006 at head 3043d4d108d22331d8de4448a6bf66e829182f1d. Central exact-name Actions artifacts are the durable dispatch ledger; existing review workflows remain authoritative for the final verdict and failure evidence.

[seonghobae]

Resolved merge conflicts against origin/develop (749511c): union-merged AGENTS.md/CHANGELOG.md bullets, sentence-merged CLAUDE.md, merged Workspace.tsx imports into a single deduplicated i18n import (createTranslator, detectPreferredLocale, translateSectionFormLabel) + firstRangeSqueeze, unioned en/ko locale tails (JSON valid, en/ko symmetric). Merged legacy .Jules/palette.md into canonical .jules/palette.md, dropped alias. Duplicate-import scan clean, no conflict markers remain. Merge head: de0098b.

[devin-ai-integration]

Devin Review found 1 new potential issue.