feat(workspace): name tonight's first harmonic function on the map - #1005
feat(workspace): name tonight's first harmonic function on the map#1005seonghobae wants to merge 16 commits into
Conversation
Surface owned harmony.functionLabel as the next rehearsal action so the room can lock the part function before starting. Open moves to the renderer-owned song-structure section. Do not invent that copy from groove, cue, simplification, overlap, range, chord labels, setup notes, confirmed overrides, harmonic explanations, or confidence notes.
|
Warning Review limit reachedNext included review available in 28 minutes. View limit detailsLimit details: You’ve used the included review currently available. You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Review configuration: ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (26)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Re-review request for exact head |
# Conflicts: # AGENTS.md # CHANGELOG.md # CLAUDE.md # apps/desktop/src/features/workspace/Workspace.tsx # apps/desktop/src/locales/en/common.json # apps/desktop/src/locales/ko/common.json
|
Resolved merge conflicts against origin/develop (749511c): union-merged AGENTS.md/CHANGELOG.md bullets, sentence-merged CLAUDE.md, kept both import sets in Workspace.tsx (FirstHarmonicFunctionCallout + firstRangeSqueeze), unioned en/ko locale tails (JSON valid, en/ko symmetric). Merged legacy .Jules/palette.md into canonical .jules/palette.md, dropped alias. No conflict markers remain. Merge head: 7ae4e45. |
Buyer next action
The mounted rehearsal workspace now names tonight's first harmonic function so the room can lock the owned part function before rehearsal starts.
Protected base:
develop@acdbea6344fe1231c39535b575f4de35e4c607c9.What the player sees
harmony.functionLabelcopy, the labeled section, and the time.Authority boundary
harmonicExplanation, or confidence notes.section.idis never DOM-ID authority.Docs
AGENTS.md, CLAUDE.md, ARCHITECTURE.md, CHANGELOG.md, and
docs/design-system/component-contract.mdname this next action. Reduced-motion Open usesbehavior: "auto".Dependency / merge gate
pdfjs-dist/nanoid/undiciHIGH findings are not copied or suppressed here.