feat(network): add bounded WebSocket frame transport - #204
Merged
seonghobae merged 66 commits intoAug 26, 2026
Conversation
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
seonghobae
added a commit
that referenced
this pull request
Aug 22, 2026
seonghobae
added a commit
that referenced
this pull request
Aug 22, 2026
seonghobae
marked this pull request as ready for review
August 26, 2026 12:45
seonghobae
merged commit Aug 26, 2026
a4240df
into
feat/webdriver-bidi-websocket-handshake-response
2 checks passed
This was referenced Aug 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR owns the bounded RFC 6455 frame-transport slice over an established, peer-verified WebDriver BiDi WebSocket stream. It remains narrower than BiDi message parsing or browser authority: one exact stream can write masked client text/Pong frames and read one bounded server frame without resolving, reconnecting, opening a second socket, or granting Agent capabilities.
Current stack truth
0c8b39b2f31979fde0766f86ce71c7b870047b61(feat/webdriver-bidi-websocket-handshake-response);c1bc7e78f3a9debf4f517fb6b5f11dd67be4ad92;Production and repair contract
WebDriverBiDiWebSocketMaskKey; the validated public boundary rejects immediately consecutive reuse before a second wire emission without imposing an unbounded/global uniqueness requirement.1004,1005,1006, and1015; extension/application semantic interpretation remains above this raw framing boundary.Current-head evidence
The immediately preceding head
9e550a4563c1025c944898b943cc6607f2ffd46fhad Rust contracts GREEN but exact coverage enforcement exposed one uncovered function/line and 12 regions. The failure was traced to a redundant inline test module inwebdriver_bidi_websocket_raw_redacted.rs, while the stronger dedicated diagnostic-redaction test module already exercises the required behavior. Current headc1bc7e78f3a9debf4f517fb6b5f11dd67be4ad92removes only that duplicate test harness.For the unchanged current head, CodeRabbit and Devin status contexts are successful and all current inline review threads are resolved. No native GitHub Actions workflow run is currently attached to this exact head, so Rust contracts, exact four-axis production coverage, SAST, Security Scan, OpenCode/Noema/Strix, Manifest V3, SBOM/provenance, or any other gate are not claimed current until they execute against this unchanged SHA. The predecessor run is retained only as causal evidence for the repaired coverage-harness defect.
Current formal review inventory contains COMMENTED automation reviews and no qualifying independent APPROVED review. Passing automation/status is not independent approval.
Safety boundary
This slice does not authenticate Chromium/ChromeDriver process provenance, establish current OriginWeave session/context/origin/document authority, authorize policy or typed input, mint durable node handles, execute a browser action, prove a post-condition, perform DNS/reconnect/proxy fallback, or substitute TLS identity. It only advances bounded RFC 6455 framing on the exact peer-verified stream.
Protected-main
AGENTS.mdremains authoritative. This scheduled actor does not merge, self-approve, force-push, destructively rebase, alter workflows/rulesets, add secrets, weaken checks, tag, release, publish, or promote stale evidence.