feat(network): validate WebSocket opening response - #198
Draft
seonghobae wants to merge 14 commits into
Draft
Conversation
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: trueThanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This was referenced Aug 20, 2026
seonghobae
added a commit
that referenced
this pull request
Aug 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
d5c55e83a6f55a57aac989e3440863a789d4b418.UpgradeandConnection: Upgradetokens, and the client-key-correlatedSec-WebSocket-Acceptvalue.Debugfor the raw client-key and handshake-plan production types.CHANGELOG.mdand browser-agent-protocol doctoring with RFC 6455 evidence.No predecessor check, review, approval, coverage, mergeability, synthetic-merge, or stale-head evidence transfers to this head.
Test-first repair lineage
The branch had diverged from current PR #195 and still derived
Debugfor the rawWebDriverBiDiWebSocketClientKeyandWebDriverBiDiWebSocketHandshakePlan, exposing the RFC 6455 client nonce through diagnostic rendering. The parent-owned redaction regression was reproduced as RED on the equivalent parent test-only head (30da73a684eacd01c78472dc0120258965480091, CI32569217148, Rust job97022153631), where both nonce-redaction tests failed before the production redaction existed.The same regression was then carried onto this canonical branch and the production boundary was repaired by replacing derived
Debugwith deterministic redacted implementations. The child was structurally rejoined to exact current parentd5c55e83a6f55a57aac989e3440863a789d4b418without discarding its opening-response validation work.Exact-current evidence
Current exact head:
0c8b39b2f31979fde0766f86ce71c7b870047b61.32934250981: success.98072330535: success — repository contracts, canonical formatting, locked workspace/all-target check, tests, strict Clippy, and rustdoc all succeeded on Rust 1.97.1.98072330593: success with exact owned-production function/line/region/branch enforcement on this unchanged head.9594321529, digestsha256:18e933fce4a4ad42c5f8bc34abb275fbc202635122279467180953ff9149b34f.d5c55e83a6f55a57aac989e3440863a789d4b418; the child is strictly ahead with no current-parent work discarded.Same-head SAST/Semgrep, Security Scan, Manifest V3, OpenCode, Noema, or Strix success is not claimed unless separately present on this exact head.
Safety boundary
This slice proves bounded RFC 6455 opening-response validation and nonce-safe diagnostics only. It does not authenticate Chromium/ChromeDriver process provenance, implement WebSocket frame/message semantics, grant browser/page/policy/Agent authority, substitute TLS, resolve DNS, reconnect, or inherit ambient authority.
Protected-main
AGENTS.mdremains authoritative. This scheduled actor does not merge, self-approve, alter workflows/rulesets, add secrets, weaken checks, tag, publish, or promote stale evidence.