perf: keep authenticated web reads responsive - #633
Merged
seonghobae merged 4 commits intoAug 25, 2026
Merged
Conversation
…main) The similar-VOC candidate fetch already carried a suppression, but its Safe SQL reason sat three lines above the audited call while the review contract requires the immediately preceding line. Collapse the comment to one adjacent line; the counted total stays 36 because this repairs an existing site rather than adding one.
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
seonghobae
enabled auto-merge (squash)
August 25, 2026 13:32
seonghobae
changed the base branch from
main
to
fix/global-ask-embedding-pool-release
August 25, 2026 13:34
seonghobae
disabled auto-merge
August 25, 2026 13:35
seonghobae
force-pushed
the
fix/k6-authenticated-capacity
branch
from
August 25, 2026 13:36
66d0f52 to
fc57c23
Compare
seonghobae
merged commit Aug 25, 2026
ccb4bb9
into
fix/global-ask-embedding-pool-release
1 of 4 checks passed
This was referenced Aug 25, 2026
seonghobae
added a commit
that referenced
this pull request
Aug 25, 2026
* fix(ask): release pool before embedding provider work * style: keep load evidence reviewable * docs(gaps): refresh protected delivery evidence * fix(ask): reject blank embedding requests * fix(ask): preserve unavailable embedding short circuit * fix(ask): honor validated precomputed embeddings * fix(ask): honor precomputed embedding envelope * fix(k6): reject unitless request timeouts * fix(migrations): replay global ask queue safely * fix(ask): reject nonfinite embeddings * perf: keep authenticated web reads responsive (#633) * fix(backend): make the similar-VOC SQL audit reason adjacent (hotfix main) The similar-VOC candidate fetch already carried a suppression, but its Safe SQL reason sat three lines above the audited call while the review contract requires the immediately preceding line. Collapse the comment to one adjacent line; the counted total stays 36 because this repairs an existing site rather than adding one. * perf: keep authenticated web reads responsive * docs: record authenticated capacity comparison --------- Co-authored-by: seonghobae <seonghobae@users.noreply.github.com> * feat(semantic): nominate Ask evidence candidates --------- Co-authored-by: seonghobae <seonghobae@users.noreply.github.com>
seonghobae
added a commit
that referenced
this pull request
Aug 27, 2026
* fix(ask): release pool before embedding provider work * style: keep load evidence reviewable * docs(gaps): refresh protected delivery evidence * fix(ask): reject blank embedding requests * fix(ask): preserve unavailable embedding short circuit * fix(ask): honor validated precomputed embeddings * fix(ask): honor precomputed embedding envelope * fix(k6): reject unitless request timeouts * fix(migrations): replay global ask queue safely * fix(ask): reject nonfinite embeddings * perf: keep authenticated web reads responsive (#633) * fix(backend): make the similar-VOC SQL audit reason adjacent (hotfix main) The similar-VOC candidate fetch already carried a suppression, but its Safe SQL reason sat three lines above the audited call while the review contract requires the immediately preceding line. Collapse the comment to one adjacent line; the counted total stays 36 because this repairs an existing site rather than adding one. * perf: keep authenticated web reads responsive * docs: record authenticated capacity comparison --------- Co-authored-by: seonghobae <seonghobae@users.noreply.github.com> * fix(verification): persist completed provider results * fix: count only claimed relation verifications * fix: fence concurrent relation verification and migration drift * fix: avoid evaluating absent migration indexes * fix(ci): document trusted eligibility SQL * test(ask): activate embedding diagnostics path * fix(verification): fence deleted evidence rows * fix(lineage): preserve landing tie order * fix(lineage): retain string tie-break contract * fix(verification): restore incremental relation persistence * test(db): execute Global Ask migration replay * fix(verification): fence deleted evidence --------- Co-authored-by: seonghobae <seonghobae@users.noreply.github.com> Co-authored-by: opencode-agent[bot] <219766164+opencode-agent[bot]@users.noreply.github.com> Co-authored-by: Codex <codex@localhost>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Outcome
/api/lineagelanding ABAC, ordering, node limit, and edge bound in PostgreSQL instead of loading all 43,189 authorized runtime rows before limiting in PythonVerification
71 passedacross lineage ingestion, relation verification, period report, config, k6 contract, and public-docstring suites809.03 ms / 6.18 s / 6.22 s,0.618 req/s; VU104.63 s / 20.10 s / 20.46 s,1.531 req/s; VU2525.35 s / 33.59 s / 36.30 s,1.046 req/s, 6 iterations179.52 ms / 3.43 s / 4.17 s,1.067 req/s; VU101.88 s / 20.80 s / 21.04 s,1.487 req/s; VU2522.03 s / 29.78 s / 31.38 s,2.411 req/s, 25 iterationsa700374e, 4 VUs for 60 s: 36 iterations, 110 HTTP requests, 0 failures; overall median/p95/p99392.15 ms / 8.82 s / 9.68 s,1.644 req/s; posts/lineage read3.21 s / 9.14 s / 9.89 s; Ask polling41.39 ms / 413.16 ms / 462.65 msAll 36 exact-head iterations observed the Ask lifecycle state. The remaining reader tail is recorded explicitly and is not presented as an SLO or capacity ceiling. The existing harness's #627 token renewal is preserved.