Skip to content

fix: retain completed relation verification results - #635

Closed
seonghobae wants to merge 20 commits into
mainfrom
fix/k6-authenticated-capacity
Closed

fix: retain completed relation verification results#635
seonghobae wants to merge 20 commits into
mainfrom
fix/k6-authenticated-capacity

Conversation

@seonghobae

@seonghobae seonghobae commented Aug 25, 2026

Copy link
Copy Markdown
Contributor

Summary

  • persist each completed relation verification before starting the next provider call
  • retain successful progress when a later counterparty provider call fails
  • add a regression test for partial progress preservation

Verification

  • uv run --extra dev pytest -q tests/test_relation_verification_internal.py
  • git diff origin/main...HEAD --check

Follow-up to the actionable review finding on #633.


Open in Devin Review

…ing-pool-release

# Conflicts:
#	docs/adr/README.md
#	docs/operability/http-concurrency-evidence.md
#	docs/product-technical-gap-baseline.md
#	scripts/k6_http_e2e.js
…lease' into fix/global-ask-embedding-pool-release

# Conflicts:
#	backend/app/post_chat_ingestion.py
…lease' into fix/global-ask-embedding-pool-release

# Conflicts:
#	backend/app/post_chat_ingestion.py
#	tests/test_global_ask_sources.py
…lease' into fix/global-ask-embedding-pool-release
…lease' into fix/global-ask-embedding-pool-release
@coderabbitai

coderabbitai Bot commented Aug 25, 2026

Copy link
Copy Markdown

Warning

Review limit reached

Next included review available in 15 minutes.

View limit details

Limit details: You’ve used the included review currently available.

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Learn how review limits work.

Review configuration:

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 117bb7cc-0d5e-4a71-b0cb-fb7ef7834ce6

📥 Commits

Reviewing files that changed from the base of the PR and between 04e6b61 and b63f1e3.

📒 Files selected for processing (24)
  • Makefile
  • backend/app/config.py
  • backend/app/global_ask_queue.py
  • backend/app/lineage_ingestion.py
  • backend/app/main.py
  • backend/app/post_chat_ingestion.py
  • backend/app/relation_verification_ingestion.py
  • backend/app/report_ingestion.py
  • backend/tests/test_config.py
  • docker-compose.yml
  • docs/adr/0213-global-ask-embedding-pool-release.md
  • docs/adr/README.md
  • docs/operability/http-concurrency-evidence.md
  • docs/product-requirements.md
  • docs/product-technical-gap-baseline.md
  • migrations/0165_global_ask_job.sql
  • migrations/0203_global_ask_authorization_scope.sql
  • scripts/k6_http_e2e.js
  • tests/test_global_ask_queue.py
  • tests/test_global_ask_sources.py
  • tests/test_k6_http_e2e_contract.py
  • tests/test_lineage_ingestion.py
  • tests/test_migration_replay.py
  • tests/test_relation_verification_internal.py

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@seonghobae
seonghobae enabled auto-merge (squash) August 25, 2026 13:38
@seonghobae

Copy link
Copy Markdown
Contributor Author

Superseded by the same reviewed fix at 143a6a3 on active parent PR #629; keeping one protected-main delivery path avoids duplicate merge/check state.

@seonghobae seonghobae closed this Aug 25, 2026
auto-merge was automatically disabled August 25, 2026 13:39

Pull request was closed

devin-ai-integration[bot]

This comment was marked as resolved.

@seonghobae seonghobae reopened this Aug 25, 2026
@seonghobae
seonghobae enabled auto-merge (squash) August 25, 2026 13:49
@seonghobae

Copy link
Copy Markdown
Contributor Author

Composed the exact relation-claim fix into active protected-main PR #629 at . Closing this duplicate delivery path; no review or check evidence transfers, and #629 must pass its own exact-head gates.

@seonghobae seonghobae closed this Aug 25, 2026
auto-merge was automatically disabled August 25, 2026 14:05

Pull request was closed

@seonghobae

Copy link
Copy Markdown
Contributor Author

Correction: the composed exact head on active protected-main PR #629 is 238a6cdb. No review or check evidence transfers; #629 must pass its own exact-head gates.

Comment on lines +535 to +546
posts = await conn.fetch(
"select post_id, post_title, voc_type_code, visibility_code, "
"corporate_entity_id, process_unit_id, thread_group_key, created_at "
"from source_post where "
f"{SOURCE_POST_ELIGIBILITY_SQL.format(alias='source_post')} and "
"(visibility_code = 'public' or (corporate_entity_id::text = any($1::text[]) "
"and (cardinality($2::text[]) = 0 or process_unit_id::text = any($2::text[])))) "
"order by created_at desc, post_id desc limit $3",
list(corporate_entity_ids),
list(process_unit_ids),
limit + 1,
)
Comment on lines +535 to +546
posts = await conn.fetch(
"select post_id, post_title, voc_type_code, visibility_code, "
"corporate_entity_id, process_unit_id, thread_group_key, created_at "
"from source_post where "
f"{SOURCE_POST_ELIGIBILITY_SQL.format(alias='source_post')} and "
"(visibility_code = 'public' or (corporate_entity_id::text = any($1::text[]) "
"and (cardinality($2::text[]) = 0 or process_unit_id::text = any($2::text[])))) "
"order by created_at desc, post_id desc limit $3",
list(corporate_entity_ids),
list(process_unit_ids),
limit + 1,
)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants