security: reconstruct exact connection-pool policy boundary on integrated timeout head - #169
Closed
seonghobae wants to merge 7 commits into
Conversation
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
seonghobae
marked this pull request as ready for review
August 11, 2026 06:21
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Replace stale stack PR #151 after its predecessor #149 was superseded by integrated-main timeout reconstruction #158. Historical checks, reviews, approvals, mergeability and base identity do not transfer.
Test-first RED
24dbd89ca6f89657380702b235d03f1bafdad3e0;0dc1ce33bbcab2d36ff0812db3b28f6c15863205;tests/test_connection_pool_policy_type_boundary.py.The regression requires both public policy constructors to reject an
EgressConnectionPoolPolicysubclass before subclass-controlled attributes can replace reviewed finite pool ceilings. If hosted exact-head CI reproduces only this intended boundary, apply only the exact construction guard, prove GREEN, then reconstruct the directly affected operator/research guidance and release-history contract test-first.Preserve #158's exact timeout-policy type boundary and protected-main security/resource semantics. Keep Draft until predecessor acceptance and exact-current-head review/security evidence. Aggregate Security Scan success is not dependency-review acceptance while the actual pinned Dependency review action is skipped.