Skip to content

security: reconstruct exact connection-pool policy boundary on current timeout head - #182

Closed
seonghobae wants to merge 27 commits into
security/reconstruct-timeout-policy-type-on-method-7faffrom
security/reconstruct-connection-pool-policy-type-aacd5b
Closed

security: reconstruct exact connection-pool policy boundary on current timeout head#182
seonghobae wants to merge 27 commits into
security/reconstruct-timeout-policy-type-on-method-7faffrom
security/reconstruct-connection-pool-policy-type-aacd5b

Conversation

@seonghobae

@seonghobae seonghobae commented Aug 11, 2026

Copy link
Copy Markdown
Contributor

Purpose

Replace stale stacked PR #169 with the exact current connection-pool policy candidate on the current timeout-policy head. Historical checks, reviews, approvals, mergeability, and base identity are not transferred.

Exact current identity

TDD / validation

The focused regression requires both public policy constructors to reject an EgressConnectionPoolPolicy subclass before subclass-controlled pool capacity can replace reviewed finite limits. Exact current local Python 3.14 evidence: 939 tests passed; production statement/branch coverage is 100% (1704/1704, 576/576); Ruff, hourly product-guard self-test, and compileall pass.

Keep Draft while predecessor #158 is unintegrated. Aggregate Security Scan success is not dependency-review acceptance while the actual pinned Dependency review action is skipped; .github#897 remains the central prerequisite. No self-approval, Admin merge, bypass, or auto-merge.

@coderabbitai

coderabbitai Bot commented Aug 11, 2026

Copy link
Copy Markdown

Warning

Review limit reached

@seonghobae, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 39 minutes

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 88db1bee-4962-49f5-b5b5-79fc4fc2dacb

📥 Commits

Reviewing files that changed from the base of the PR and between 496d817 and 2cce1de.

📒 Files selected for processing (5)
  • CHANGELOG.md
  • docs/research/connection-pool-resource-limits.md
  • src/egressweave/policy.py
  • tests/test_connection_pool_policy_type_boundary.py
  • tests/test_connection_pool_policy_type_documentation.py

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Copy link
Copy Markdown
Contributor Author

@coderabbitai full review

@coderabbitai

coderabbitai Bot commented Aug 11, 2026

Copy link
Copy Markdown
⚠️ Action not completed

Review rate limited.


Your included review limit is currently reached under our Fair Usage Limits Policy. This review may still proceed through usage-based billing if eligible. Your next included review will be available in 20 minutes.

@seonghobae
seonghobae marked this pull request as ready for review August 11, 2026 16:17
@seonghobae
seonghobae marked this pull request as draft August 11, 2026 18:35
Integrate protected main 1d2e190 without rebasing. Preserve the current timeout-policy source/tests/research delta and take protected-main CHANGELOG as the initial merge resolution so integrated documentation parity can be revalidated independently.
@seonghobae
seonghobae marked this pull request as draft August 12, 2026 01:02

Copy link
Copy Markdown
Contributor Author

Exact-head reconciliation complete: predecessor #158 moved to 496d81709ad63be6b921510c447e7d2393daed96, and this PR is now 2cce1de4a153b8b844b4dfd80de868f0667b7cae. Local Python 3.14 validation on the reconciled tree: 939 passed, 100% production statement/branch coverage (1704/1704, 576/576), Ruff, product-guard self-test, and compileall all pass. It remains Draft behind #158; no historical evidence transfer and no merge until independent review plus accepted central dependency-review execution.

Copy link
Copy Markdown
Contributor Author

@coderabbitai review

@coderabbitai

coderabbitai Bot commented Aug 12, 2026

Copy link
Copy Markdown
⚠️ Action not completed

Review rate limited.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

@seonghobae
seonghobae changed the base branch from security/reconstruct-timeout-policy-type-dd0324 to security/reconstruct-timeout-policy-type-on-method-7faf August 14, 2026 08:28

Copy link
Copy Markdown
Contributor Author

Superseded by #221, which reconstructs the exact EgressConnectionPoolPolicy type boundary on the current method/timeout stack with hosted RED evidence, minimal GREEN implementation, migration documentation, and exact-head 100% statement/branch coverage. Historical checks, reviews, base identity, and mergeability from this stale branch are not acceptance evidence and are intentionally not transferred.

@seonghobae seonghobae closed this Aug 14, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant