Skip to content

security: reconstruct exact request-timeout policy boundary on current main - #149

Closed
seonghobae wants to merge 6 commits into
mainfrom
security/reconstruct-timeout-policy-type-d3498ec
Closed

security: reconstruct exact request-timeout policy boundary on current main#149
seonghobae wants to merge 6 commits into
mainfrom
security/reconstruct-timeout-policy-type-d3498ec

Conversation

@seonghobae

@seonghobae seonghobae commented Aug 10, 2026

Copy link
Copy Markdown
Contributor

Superseded by integrated-main reconstruction

This historical reconstruction is closed without merge because protected main advanced from its base d3498ec9455bfd3f3bb7df78c914de0a5d1120fc to dd0324c0d7edb6effc74737039d1e754af09f5aa after the candidate was built.

Ready PR #158 preserves the same timeout-policy boundary, regression coverage, operator guidance, documentation contract and release history on the exact integrated base. Its current exact head is 24dbd89ca6f89657380702b235d03f1bafdad3e0; CI 31445055200 and SAST 31445055212 are green with exact 100% owned production statement/branch coverage. Security Scan 31445055197 still has the actual pinned Dependency review step skipped, so #158 is not merge-ready until the read-only central dependency-review repair is integrated and the unchanged head is revalidated.

Historical evidence in this PR remains audit history; no check, review, approval, base identity or mergeability transfers to #158.

@coderabbitai

coderabbitai Bot commented Aug 10, 2026

Copy link
Copy Markdown

Review Change Stack

Important

Review skipped

No new commits to review since the last review.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 97539bb2-e127-4fd1-8923-e79a21576836

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
📝 Walkthrough

Walkthrough

EgressPolicyEgressTimeoutPolicy의 정확한 타입만 허용합니다. 하위 클래스는 transport dispatch 전에 TypeError로 거부됩니다. 회귀 테스트와 문서화 계약 테스트가 이 동작을 검증합니다.

Changes

타임아웃 정책 경계 강화

Layer / File(s) Summary
정확한 타입 검증과 회귀 테스트
src/egressweave/policy.py, tests/test_timeout_policy_type_boundary.py
request_timeout_policy 검증이 정확한 EgressTimeoutPolicy 타입만 허용합니다. from_hostsfrom_authorities는 하위 클래스 인스턴스를 TypeError로 거부합니다.
문서 및 변경 로그 계약
docs/research/request-timeout-boundaries.md, CHANGELOG.md, tests/test_timeout_policy_type_documentation.py
정확한 타입 제한과 as_httpcore_timeout() 디스패치 전 거부 동작을 문서화합니다. 문서와 변경 로그의 필수 문구를 테스트합니다.

Estimated code review effort: 2 (Simple) | ~10 minutes

Possibly related issues

Possibly related PRs

  • ContextualWisdomLab/EgressWeave#100 — transport 처리 전에 신뢰할 수 없는 하위 클래스 입력을 거부한다는 코드 수준의 보안 경계 강화와 관련됩니다.
🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed 제목은 현재 main에서 요청 타임아웃 정책의 정확한 타입 경계를 복원하는 주요 변경 사항을 명확하게 요약합니다.
✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch security/reconstruct-timeout-policy-type-d3498ec

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Copy link
Copy Markdown
Contributor Author

@coderabbitai review

@coderabbitai

coderabbitai Bot commented Aug 10, 2026

Copy link
Copy Markdown
⚠️ Action not completed

Already reviewed.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant