Skip to content
Closed
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/osv-scanner-pr.yml
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@ jobs:
# full old/new osv-scanner JSON into job outputs unconditionally, tripping
# GitHub's 1,048,576-byte job-outputs cap and failing the run. Same nested
# action pins as v2.3.8; only the Export step is now conditional.
uses: google/osv-scanner-action/.github/workflows/osv-scanner-reusable-pr.yml@3a7550f43ba5b58905a821ce3a0ed24c4858b3f4 # v2.3.8 + export-results gate
uses: google/osv-scanner-action/.github/workflows/osv-scanner-reusable-pr.yml@ffa0a5f39214d80778c9b494822d94d0d9668458 # v2.3.8 + export-results gate

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Stale version label on bumped OSV pin

The uses: pin is bumped to ffa0a5f, a v2.5.1-based commit per the upstream history, but its trailing comment still reads # v2.3.8 + export-results gate. The label now misstates the pinned version.

Prompt for agents
The pinned SHA on the uses: line was bumped to ffa0a5f, which upstream commit history shows is based on osv-scanner-action v2.5.1 with a JSON export fix, not v2.3.8. Update the trailing comment on this line and the explanatory block above it (currently referencing 3a7550f and "v2.3.8 + export-results gate") so they accurately describe the new pinned version and re-verify that the export-results/job-outputs-cap rationale still holds for v2.5.1.
Open in Devin Review

Was this helpful? React with 👍 or 👎 to provide feedback.

Comment on lines 39 to +42

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔍 Verify export-results gate persists at v2.5.1

The pin rationale relies on the export-results gate (default false) to avoid tripping GitHub's job-outputs cap that v2.3.8 hit. The new pin is v2.5.1-based with a JSON export fix. Confirm v2.5.1 still gates JSON output behind export-results and defaults it false, otherwise the cap failure can return.

(Refers to this code)

Open in Devin Review

Was this helpful? React with 👍 or 👎 to provide feedback.

permissions:
actions: read
contents: read
Expand Down
Loading