chore(deps): bump google/osv-scanner-action/.github/workflows/osv-scanner-reusable-pr.yml from 3a7550f43ba5b58905a821ce3a0ed24c4858b3f4 to ffa0a5f39214d80778c9b494822d94d0d9668458 - #1310
Conversation
| # GitHub's 1,048,576-byte job-outputs cap and failing the run. Same nested | ||
| # action pins as v2.3.8; only the Export step is now conditional. | ||
| uses: google/osv-scanner-action/.github/workflows/osv-scanner-reusable-pr.yml@3a7550f43ba5b58905a821ce3a0ed24c4858b3f4 # v2.3.8 + export-results gate | ||
| uses: google/osv-scanner-action/.github/workflows/osv-scanner-reusable-pr.yml@ffa0a5f39214d80778c9b494822d94d0d9668458 # v2.3.8 + export-results gate |
There was a problem hiding this comment.
🟡 Stale version label on bumped OSV pin
The uses: pin is bumped to ffa0a5f, a v2.5.1-based commit per the upstream history, but its trailing comment still reads # v2.3.8 + export-results gate. The label now misstates the pinned version.
Prompt for agents
The pinned SHA on the uses: line was bumped to ffa0a5f, which upstream commit history shows is based on osv-scanner-action v2.5.1 with a JSON export fix, not v2.3.8. Update the trailing comment on this line and the explanatory block above it (currently referencing 3a7550f and "v2.3.8 + export-results gate") so they accurately describe the new pinned version and re-verify that the export-results/job-outputs-cap rationale still holds for v2.5.1.
Was this helpful? React with 👍 or 👎 to provide feedback.
| # full old/new osv-scanner JSON into job outputs unconditionally, tripping | ||
| # GitHub's 1,048,576-byte job-outputs cap and failing the run. Same nested | ||
| # action pins as v2.3.8; only the Export step is now conditional. | ||
| uses: google/osv-scanner-action/.github/workflows/osv-scanner-reusable-pr.yml@3a7550f43ba5b58905a821ce3a0ed24c4858b3f4 # v2.3.8 + export-results gate | ||
| uses: google/osv-scanner-action/.github/workflows/osv-scanner-reusable-pr.yml@ffa0a5f39214d80778c9b494822d94d0d9668458 # v2.3.8 + export-results gate |
There was a problem hiding this comment.
🔍 Verify export-results gate persists at v2.5.1
The pin rationale relies on the export-results gate (default false) to avoid tripping GitHub's job-outputs cap that v2.3.8 hit. The new pin is v2.5.1-based with a JSON export fix. Confirm v2.5.1 still gates JSON output behind export-results and defaults it false, otherwise the cap failure can return.
(Refers to this code)
Was this helpful? React with 👍 or 👎 to provide feedback.
105e04d to
da66ab7
Compare
3279a1e to
2a80e3f
Compare
…nner-reusable-pr.yml Bumps [google/osv-scanner-action/.github/workflows/osv-scanner-reusable-pr.yml](https://github.com/google/osv-scanner-action) from 3a7550f43ba5b58905a821ce3a0ed24c4858b3f4 to ffa0a5f39214d80778c9b494822d94d0d9668458. - [Release notes](https://github.com/google/osv-scanner-action/releases) - [Commits](google/osv-scanner-action@3a7550f...ffa0a5f) --- updated-dependencies: - dependency-name: google/osv-scanner-action/.github/workflows/osv-scanner-reusable-pr.yml dependency-version: ffa0a5f39214d80778c9b494822d94d0d9668458 dependency-type: direct:production ... Signed-off-by: dependabot[bot] <support@github.com>
2a80e3f to
3c674b2
Compare
Bumps google/osv-scanner-action/.github/workflows/osv-scanner-reusable-pr.yml from 3a7550f43ba5b58905a821ce3a0ed24c4858b3f4 to ffa0a5f39214d80778c9b494822d94d0d9668458.
Commits
ffa0a5fMerge pull request #142 from google/fix-json-export-code259ba4aFix JSON results export6e4298eMerge pull request #141 from google/update-to-v2.5.15957b4eUpdate unified workflow example to point to v2.5.1 reusable workflows880d9b5Update reusable workflows to point to v2.5.1 actionsbaa4139"Update actions to use v2.5.1 osv-scanner image"f4cfcc0Merge pull request #117 from renovate-bot/renovate/workflowsdfd4cd1Update workflowse13f842Merge pull request #133 from renovate-bot/renovate/major-workflows8deb546Merge pull request #140 from google/update-to-v2.5.0