London | 26-ITP-May | Hugh Mills | Sprint 2 | Wireframe to web code #1405
+56
−10
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -24,23 +24,27 @@ As well as useful links to learn more */ | |
| --line: 1px solid; | ||
| --container: 1280px; | ||
| } | ||
|
|
||
| /* ====== Base Elements ====== | ||
| General rules for basic HTML elements in any context */ | ||
| body { | ||
| background: var(--paper); | ||
| color: var(--ink); | ||
| font: var(--font); | ||
| } | ||
|
|
||
| a { | ||
| padding: var(--space); | ||
| border: var(--line); | ||
| max-width: fit-content; | ||
| } | ||
|
|
||
| img, | ||
| svg { | ||
| width: 100%; | ||
| object-fit: cover; | ||
| } | ||
|
|
||
| /* ====== Site Layout ====== | ||
| Setting the overall rules for page regions | ||
| https://www.w3.org/WAI/tutorials/page-structure/regions/ | ||
|
|
@@ -49,11 +53,37 @@ main { | |
| max-width: var(--container); | ||
| margin: 0 auto calc(var(--space) * 4) auto; | ||
| } | ||
|
|
||
| header { | ||
| text-align:center; | ||
| max-width: fit-content; | ||
| margin-left: auto; | ||
| margin-right: auto; | ||
| } | ||
|
|
||
| h1 { | ||
| text-align:center; | ||
| font-size: 4em; | ||
| max-width: fit-content; | ||
| font-weight: bold; | ||
| font-family: 'Times New Roman', Times, serif; | ||
| } | ||
|
|
||
| #top-comment { | ||
| text-align:center; | ||
| margin-bottom: 20px; | ||
| } | ||
|
|
||
| footer { | ||
| position: fixed; | ||
| bottom: 0; | ||
| text-align: center; | ||
| color: white; | ||
| padding-top: 10px; | ||
| background-color: rgb(28, 77, 127); | ||
| width:100% | ||
| } | ||
|
Comment on lines
+57
to
85
There was a problem hiding this comment. @HM-127BTY, how could you improve the readability and the separation between blocks of code?
Author
There was a problem hiding this comment. My best guess would be spacing, keeping a clear line between them would help to break it up and make it more readable? |
||
|
|
||
| /* ====== Articles Grid Layout ==== | ||
| Setting the rules for how articles are placed in the main element. | ||
| Inspect this in Devtools and click the "grid" button in the Elements view | ||
|
|
||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@HM-127BTY, why is this anchor link UI different from the rest?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am unsure why it is doing that, could be because it is the last item in all the articles before footer? I will look into it tomorrow, hopefully with some assistance from others in the class on Saturday.