London | 26-ITP-May | Hugh Mills | Sprint 2 | Wireframe to web code#1405
Open
HM-127BTY wants to merge 5 commits into
Open
London | 26-ITP-May | Hugh Mills | Sprint 2 | Wireframe to web code#1405HM-127BTY wants to merge 5 commits into
HM-127BTY wants to merge 5 commits into
Conversation
Added images and text to main artiles, added links. Added footer info.
added styles for footer.
✅ Deploy Preview for cyf-onboarding-module ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
This comment has been minimized.
This comment has been minimized.
HM-127BTY
added
📅 Sprint 2
This comment has been minimized.
This comment has been minimized.
github-actions
Bot
removed
the
Needs Review
This comment has been minimized.
This comment has been minimized.
Author
|
removed extra image file, changed to image link from wiki page. |
This comment has been minimized.
This comment has been minimized.
1 similar comment
This comment has been minimized.
This comment has been minimized.
HM-127BTY
added
the
Needs Review
akeren
added
Review in progress
akeren
reviewed
Jun 5, 2026
akeren
left a comment
akeren
left a comment
There was a problem hiding this comment.
@HM-127BTY, your codebase structure is currently simple and easy to follow, with just two files: index.html and style.css kept in the same root directory.
As your projects grow, what might happen if you later add more CSS files, JavaScript files, images, or multiple HTML pages? How could you organise your folders so the project stays easy to navigate, scalable and maintainable now and in the future?
| <p>A Branch in git is a copy of the main folder where there has been edits or fixes done to in a controlled manner that can then be implemented to the main folder in due time. | ||
| </p> | ||
| <a href="">Read more</a> | ||
| <a href="https://en.wikipedia.org/wiki/Branching_(version_control)">Read more</a> |
There was a problem hiding this comment.
@HM-127BTY, why is this anchor link UI different from the rest?
| </article> | ||
| <article id="2nd"> | ||
| <img src="https://cdn.prod.website-files.com/64fa82cbdeed167ebaefef84/64fa868c41d7a2600b45a4d5_606de8872932076fce79ad0f_TL5vrIkw1V7VYfqA3lvvi313PuvWyzIJtAQ4HthZnsXuYXQTC4rQhEcyq40qZaYDYpBHtnnPJ0PhnmBuJ9XRLnWMrlzZE9IXIfyvYan4Xj3woYXuTrAC7kTgydlqIADE8A26ITwb.png" alt="shetched images showing a plan for desnining a website, showing areas for an image, video player and other boxes for feature text and information." > | ||
| <!-- Image from https://www.flux-academy.com/blog/20-wireframe-examples-for-web-design to help show wireframe--> |
There was a problem hiding this comment.
@HM-127BTY, could you explain why you're pushing commented code to a production environment?
| </article> | ||
| <article id="3rd"> | ||
| <img src="https://docs.wavemaker.com/learn/assets/images/branching-model-121bd320dd2f5972a5f6ce2fb19a3f4e.png" alt="Connection blue balls in a straight line starting from one called Master then connection to others with lined arrow, from First is extra arrow goign up to red balls labed Bugfix then back down to third blue ball, from 2nd blue ball extra arrow goes down to two green balls labed Feature then back to last blue ball." > | ||
| <!-- Image from https://docs.wavemaker.com/learn/blog/2021/09/17/git-branching-strategy/ to aid in display of Git Branch--> |
There was a problem hiding this comment.
@HM-127BTY, could you explain why you're pushing commented code to a production environment?
Comment on lines
+52
to
77
| header { | ||
| text-align:center; | ||
| max-width: fit-content; | ||
| margin-left: auto; | ||
| margin-right: auto; | ||
| } | ||
| h1 { | ||
| text-align:center; | ||
| font-size: 4em; | ||
| max-width: fit-content; | ||
| font-weight: bold; | ||
| font-family: 'Times New Roman', Times, serif; | ||
| } | ||
| #top-comment { | ||
| text-align:center; | ||
| margin-bottom: 20px; | ||
| } | ||
| footer { | ||
| position: fixed; | ||
| bottom: 0; | ||
| text-align: center; | ||
| color: white; | ||
| padding-top: 10px; | ||
| background-color: rgb(28, 77, 127); | ||
| width:100% | ||
| } |
There was a problem hiding this comment.
@HM-127BTY, how could you improve the readability and the separation between blocks of code?
| <p> | ||
| Lorem ipsum dolor sit amet consectetur adipisicing elit. Quisquam, | ||
| voluptates. Quisquam, voluptates. | ||
| <article id="1st"> |
There was a problem hiding this comment.
@HM-127BTY, could you think of a better name for this id?
| </p> | ||
| <a href="https://en.wikipedia.org/wiki/README">Read more</a> | ||
| </article> | ||
| <article id="2nd"> |
There was a problem hiding this comment.
@HM-127BTY, could you think of a better name for this id?
| </p> | ||
| <a href="https://en.wikipedia.org/wiki/Website_wireframe">Read more</a> | ||
| </article> | ||
| <article id="3rd"> |
There was a problem hiding this comment.
@HM-127BTY, could you think of a better name for this id?
akeren
added
Reviewed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Learners, PR Template
Self checklist
Changelist
Using the Wireframe I was able to create the website to match the style required and filled out the information that was required.