-
-
Notifications
You must be signed in to change notification settings - Fork 501
London | 26-ITP-May | Vito Moratti | Sprint 2 | Feature/Wireframe #1397
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
vmoratti
wants to merge
16
commits into
CodeYourFuture:main
Choose a base branch
from
vmoratti:feature/Wireframe
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+69
−33
Open
Changes from all commits
Commits
Show all changes
16 commits
Select commit
Hold shift + click to select a range
998b7d2
start from scratch again
vmoratti ba18401
add index.htmml file that i wrote before
vmoratti 9c2ee9a
add style.css file, and styling to the <legend> field
vmoratti 4c82518
final commmit
vmoratti 8c176e0
create index.html file fromm the one i mmade before
vmoratti 4a736ca
add style.css file, add images file
vmoratti c3640cf
change paths to images and immages names
vmoratti bf67e81
add placeholde.svg file
vmoratti 5d58e28
hopefuly final commit
vmoratti 36bf252
change picture names
vmoratti fbde610
Refactor index.html to create a template structure
vmoratti e2fdc78
Delete Form-Controls/style.css
vmoratti cd2858a
Revise introduction and update Git branch link
vmoratti b53784c
Add header styles for text alignment and padding
vmoratti 6806a89
Add max-height to anchor elements in style.css
vmoratti 38bfb5f
Add height to images and SVGs in style.css
vmoratti File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,33 +1,62 @@ | ||
| <!DOCTYPE html> | ||
| <html lang="en"> | ||
| <head> | ||
| <meta charset="UTF-8" /> | ||
| <meta name="viewport" content="width=device-width, initial-scale=1.0" /> | ||
| <title>Wireframe</title> | ||
| <link rel="stylesheet" href="style.css" /> | ||
| </head> | ||
| <body> | ||
| <header> | ||
| <h1>Wireframe</h1> | ||
|
|
||
| <head> | ||
| <meta charset="UTF-8" /> | ||
| <meta name="viewport" content="width=device-width, initial-scale=1.0" /> | ||
| <title>Wireframe</title> | ||
| <link rel="stylesheet" href="style.css" /> | ||
| </head> | ||
|
|
||
| <body> | ||
| <header> | ||
| <h1>Wireframe</h1> | ||
| <p> | ||
| This page will show you the purpose of README file, the purpose of | ||
| Wireframe and what is branch in Git. It will include images and links to read more about each topic. | ||
| </p> | ||
|
|
||
| </header> | ||
| <main> | ||
| <article> | ||
| <img src="placeholder.jpg" alt="an image showing an example of a README file" /> | ||
| <h2> | ||
| What is the purpose of a README file? | ||
| </h2> | ||
| <p> | ||
| This is the default, provided code and no changes have been made yet. | ||
| A README file is the foundational documentation | ||
| for a software, dataset, or coding project. | ||
| It serves as a project's "front door," designed to help users quickly understand what the project does, | ||
| how to install and use it, and how to contribute | ||
| </p> | ||
| </header> | ||
| <main> | ||
| <article> | ||
| <img src="placeholder.svg" alt="" /> | ||
| <h2>Title</h2> | ||
| <p> | ||
| Lorem ipsum dolor sit amet consectetur adipisicing elit. Quisquam, | ||
| voluptates. Quisquam, voluptates. | ||
| </p> | ||
| <a href="">Read more</a> | ||
| </article> | ||
| </main> | ||
| <footer> | ||
| <a href="https://en.wikipedia.org/wiki/README">Read more</a> | ||
| </article> | ||
| <article> | ||
| <img src="wireframe.png" alt="an image showing a hand drawn sketch of what a wireframe looks like" /> | ||
| <h2>What is a Wireframe?</h2> | ||
| <p> | ||
| This is the default, provided code and no changes have been made yet. | ||
| A wireframe is a visual guide that represents the skeletal framework of a website or application. | ||
| It outlines the layout, content, and functionality of a page before any design or coding is done. | ||
| </p> | ||
| </footer> | ||
| </body> | ||
| <a href="https://en.wikipedia.org/wiki/Wireframe">Read more</a> | ||
| </article> | ||
| <article> | ||
| <img src="branch-image.jpg" alt="an image showing a diagram of a Git branch" /> | ||
| <h2>What is a Branch in Git?</h2> | ||
| <p> | ||
| A branch in Git is a lightweight movable pointer to a commit. | ||
| It allows you to diverge from the mainline of development and work on features, experiments, or bug fixes | ||
| without affecting the main codebase. | ||
| </p> | ||
| <a href="https://git-scm.com/book/en/v2/Git-Branching-Branches-in-a-Nutshell#:~:text=A%20branch%20in%20Git%20is,Note">Read more</a> | ||
| </article> | ||
| </main> | ||
| <footer> | ||
| <p> | ||
| Made by Vito. | ||
| </p><!--adding a comment to test the push and pull request, because so far | ||
| it is not working at all, adding another comment--> | ||
| </footer> | ||
| </body> | ||
|
|
||
| </html> | ||
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
This file was deleted.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@vmoratti, compare the header with the main section of the page. Does the alignment look intentional? What CSS change might help align them?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I made adjustments. The header section is centered now.