London | 26-ITP-May | Vito Moratti | Sprint 2 | Feature/Wireframe by vmoratti · Pull Request #1397 · CodeYourFuture/Module-Onboarding

vmoratti · 2026-06-01T23:40:29Z

Self checklist

I have titled my PR with Region | Cohort | FirstName LastName | Sprint | Assignment Title
My changes meet the requirements of the task
I have tested my changes
My changes follow the style guide

Changelist

I had to delete all the previous branches and redo it from scratch.

netlify · 2026-06-01T23:40:34Z

✅ Deploy Preview for cyf-onboarding-module ready!

Name	Link
🔨 Latest commit	`6806a89`
🔍 Latest deploy log	https://app.netlify.com/projects/cyf-onboarding-module/deploys/6a22ce4dd84cd700089e4dd3
😎 Deploy Preview	https://deploy-preview-1397--cyf-onboarding-module.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.
Lighthouse	2 paths audited Performance: 100 (no change from production) Accessibility: 100 (no change from production) Best Practices: 100 (no change from production) SEO: 86 (no change from production) PWA: - View the detailed breakdown and full score reports
🤖 Make changes	Run an agent on this branch

To edit notification comments on pull requests, go to your Netlify project configuration.

github-actions · 2026-06-01T23:40:49Z

Your PR couldn't be matched to an assignment in this module.

Please check its title is in the correct format, and that you only have one PR per assignment.

If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed).

If this PR needs reviewed, please add the 'Needs Review' label to this PR after you have resolved the issues listed above.

github-actions · 2026-06-01T23:40:56Z

Your PR couldn't be matched to an assignment in this module.

Please check its title is in the correct format, and that you only have one PR per assignment.

If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed).

If this PR needs reviewed, please add the 'Needs Review' label to this PR after you have resolved the issues listed above.

github-actions · 2026-06-01T23:42:00Z

Your PR couldn't be matched to an assignment in this module.

Please check its title is in the correct format, and that you only have one PR per assignment.

If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed).

If this PR needs reviewed, please add the 'Needs Review' label to this PR after you have resolved the issues listed above.

github-actions · 2026-06-01T23:43:20Z

The changed files in this PR don't match what is expected for this task.

Please check that you committed the right files for the task, and that there are no accidentally committed files from other sprints.

Please review the changed files tab at the top of the page, we are only expecting changes in this directory: ^Wireframe/

If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed).

If this PR needs reviewed, please add the 'Needs Review' label to this PR after you have resolved the issues listed above.

github-actions · 2026-06-01T23:43:37Z

The changed files in this PR don't match what is expected for this task.

Please check that you committed the right files for the task, and that there are no accidentally committed files from other sprints.

Please review the changed files tab at the top of the page, we are only expecting changes in this directory: ^Wireframe/

If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed).

If this PR needs reviewed, please add the 'Needs Review' label to this PR after you have resolved the issues listed above.

github-actions · 2026-06-02T00:04:49Z

The changed files in this PR don't match what is expected for this task.

Please check that you committed the right files for the task, and that there are no accidentally committed files from other sprints.

Please review the changed files tab at the top of the page, we are only expecting changes in this directory: ^Wireframe/

If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed).

If this PR needs reviewed, please add the 'Needs Review' label to this PR after you have resolved the issues listed above.

github-actions · 2026-06-02T00:23:55Z

The changed files in this PR don't match what is expected for this task.

Please check that you committed the right files for the task, and that there are no accidentally committed files from other sprints.

Please review the changed files tab at the top of the page, we are only expecting changes in this directory: ^Wireframe/

If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed).

If this PR needs reviewed, please add the 'Needs Review' label to this PR after you have resolved the issues listed above.

github-actions · 2026-06-03T15:31:59Z

The changed files in this PR don't match what is expected for this task.

Please check that you committed the right files for the task, and that there are no accidentally committed files from other sprints.

Please review the changed files tab at the top of the page, we are only expecting changes in this directory: ^Wireframe/

If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed).

If this PR needs reviewed, please add the 'Needs Review' label to this PR after you have resolved the issues listed above.

github-actions · 2026-06-03T15:54:02Z

The changed files in this PR don't match what is expected for this task.

Please check that you committed the right files for the task, and that there are no accidentally committed files from other sprints.

Please review the changed files tab at the top of the page, we are only expecting changes in this directory: ^Wireframe/

If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed).

If this PR needs reviewed, please add the 'Needs Review' label to this PR after you have resolved the issues listed above.

github-actions · 2026-06-03T19:10:05Z

The changed files in this PR don't match what is expected for this task.

Please check that you committed the right files for the task, and that there are no accidentally committed files from other sprints.

Please review the changed files tab at the top of the page, we are only expecting changes in this directory: ^Wireframe/

If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed).

If this PR needs reviewed, please add the 'Needs Review' label to this PR after you have resolved the issues listed above.

Removed existing form elements and added placeholders for new content.

github-actions · 2026-06-03T19:18:53Z

The changed files in this PR don't match what is expected for this task.

Please check that you committed the right files for the task, and that there are no accidentally committed files from other sprints.

Please review the changed files tab at the top of the page, we are only expecting changes in this directory: ^Wireframe/

If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed).

If this PR needs reviewed, please add the 'Needs Review' label to this PR after you have resolved the issues listed above.

github-actions · 2026-06-05T11:38:00Z

The changed files in this PR don't match what is expected for this task.

Please check that you committed the right files for the task, and that there are no accidentally committed files from other sprints.

Please review the changed files tab at the top of the page, we are only expecting changes in this directory: ^Wireframe/

If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed).

If this PR needs reviewed, please add the 'Needs Review' label to this PR after you have resolved the issues listed above.

github-actions · 2026-06-05T11:38:02Z

The changed files in this PR don't match what is expected for this task.

Please check that you committed the right files for the task, and that there are no accidentally committed files from other sprints.

Please review the changed files tab at the top of the page, we are only expecting changes in this directory: ^Wireframe/

If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed).

If this PR needs reviewed, please add the 'Needs Review' label to this PR after you have resolved the issues listed above.

github-actions · 2026-06-05T11:38:04Z

The changed files in this PR don't match what is expected for this task.

Please check that you committed the right files for the task, and that there are no accidentally committed files from other sprints.

Please review the changed files tab at the top of the page, we are only expecting changes in this directory: ^Wireframe/

If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed).

If this PR needs reviewed, please add the 'Needs Review' label to this PR after you have resolved the issues listed above.

akeren · 2026-06-05T11:40:55Z

@vmoratti, review the comments and resolve the issues highlighted...

vmoratti · 2026-06-05T11:45:14Z

I have tried to resolve it. Please advice.

akeren · 2026-06-05T11:42:58Z

+  <header>
+    <h1>Wireframe</h1>
+    <p>
+      This page will show:
+    </p>
+    <ul>
+      <li>Purpose of README file</li>
+      <li>Purpose of Wireframe</li>
+      <li>What is branch in Git</li>
+    </ul>
+  </header>


@vmoratti, compare the header with the main section of the page. Does the alignment look intentional? What CSS change might help align them?

I made adjustments. The header section is centered now.

akeren · 2026-06-05T11:47:24Z

+        It allows you to diverge from the mainline of development and work on features, experiments, or bug fixes
+        without affecting the main codebase.
+      </p>
+      <a href="https://en.wikipedia.org/wiki/Git_branch">Read more</a>


@vmoratti, why is this UI experience not the same as the rest of the links?

I have changed the link to more information about git branch.

@vmoratti, I am referring to the appearance of the button. Compare it with the rest. Think of what has to change to make it appear the same as the rest.

I added max-height to the anchor element in CSS file. "Read more" buttons appear the same size now.

akeren · 2026-06-05T11:49:23Z

I have tried to resolve it. Please advice.

@vmoratti, please try and follow these instructions 👉 https://deploy-preview-1397--cyf-onboarding-module.netlify.app/Wireframe/readme.md

github-actions · 2026-06-05T11:50:12Z

The changed files in this PR don't match what is expected for this task.

Please check that you committed the right files for the task, and that there are no accidentally committed files from other sprints.

Please review the changed files tab at the top of the page, we are only expecting changes in this directory: ^Wireframe/

If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed).

If this PR needs reviewed, please add the 'Needs Review' label to this PR after you have resolved the issues listed above.

github-actions · 2026-06-05T11:50:13Z

The changed files in this PR don't match what is expected for this task.

Please check that you committed the right files for the task, and that there are no accidentally committed files from other sprints.

Please review the changed files tab at the top of the page, we are only expecting changes in this directory: ^Wireframe/

If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed).

If this PR needs reviewed, please add the 'Needs Review' label to this PR after you have resolved the issues listed above.

Updated the content of the introduction and changed the link for more information about Git branches.

vmoratti added 6 commits June 1, 2026 23:49

start from scratch again

998b7d2

add index.htmml file that i wrote before

ba18401

add style.css file, and styling to the <legend> field

9c2ee9a

final commmit

4c82518

create index.html file fromm the one i mmade before

8c176e0

add style.css file, add images file

4a736ca

vmoratti added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Jun 1, 2026

github-actions Bot removed the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Jun 1, 2026

vmoratti added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Jun 1, 2026

github-actions Bot removed the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Jun 1, 2026

change paths to images and immages names

c3640cf

vmoratti added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Jun 2, 2026

github-actions Bot removed the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Jun 2, 2026

vmoratti added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Jun 3, 2026

github-actions Bot removed the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Jun 3, 2026

vmoratti added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Jun 3, 2026

github-actions Bot removed the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Jun 3, 2026

change picture names

36bf252

vmoratti force-pushed the feature/Wireframe branch from 0e10c81 to 36bf252 Compare June 3, 2026 19:08

vmoratti added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Jun 3, 2026

github-actions Bot removed the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Jun 3, 2026

vmoratti added 2 commits June 3, 2026 20:14

Refactor index.html to create a template structure

fbde610

Removed existing form elements and added placeholders for new content.

Delete Form-Controls/style.css

e2fdc78

vmoratti added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Jun 3, 2026

github-actions Bot removed the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Jun 3, 2026

akeren assigned vmoratti Jun 5, 2026

akeren added 📅 Sprint 2 Assigned during Sprint 2 of this module Review in progress This review is currently being reviewed. This label will be replaced by "Reviewed" soon. Module-Onboarding The name of the module. labels Jun 5, 2026

akeren self-requested a review June 5, 2026 11:37

akeren reviewed Jun 5, 2026

View reviewed changes

akeren added Reviewed Volunteer to add when completing a review with trainee action still to take. and removed Review in progress This review is currently being reviewed. This label will be replaced by "Reviewed" soon. labels Jun 5, 2026

vmoratti added 3 commits June 5, 2026 13:21

Revise introduction and update Git branch link

cd2858a

Updated the content of the introduction and changed the link for more information about Git branches.

Add header styles for text alignment and padding

b53784c

Add max-height to anchor elements in style.css

6806a89

Uh oh!

Conversation

vmoratti commented Jun 1, 2026

Changelist

Uh oh!

netlify Bot commented Jun 1, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

✅ Deploy Preview for cyf-onboarding-module ready!

Uh oh!

github-actions Bot commented Jun 1, 2026

Uh oh!

github-actions Bot commented Jun 1, 2026

Uh oh!

github-actions Bot commented Jun 1, 2026

Uh oh!

github-actions Bot commented Jun 1, 2026

Uh oh!

github-actions Bot commented Jun 1, 2026

Uh oh!

github-actions Bot commented Jun 2, 2026

Uh oh!

github-actions Bot commented Jun 2, 2026

Uh oh!

github-actions Bot commented Jun 3, 2026

Uh oh!

github-actions Bot commented Jun 3, 2026

Uh oh!

github-actions Bot commented Jun 3, 2026

Uh oh!

github-actions Bot commented Jun 3, 2026

Uh oh!

github-actions Bot commented Jun 5, 2026

Uh oh!

github-actions Bot commented Jun 5, 2026

Uh oh!

github-actions Bot commented Jun 5, 2026

Uh oh!

akeren commented Jun 5, 2026

Uh oh!

vmoratti commented Jun 5, 2026

Uh oh!

akeren Jun 5, 2026

Choose a reason for hiding this comment

Uh oh!

vmoratti Jun 5, 2026

Choose a reason for hiding this comment

Uh oh!

akeren Jun 5, 2026

Choose a reason for hiding this comment

Uh oh!

vmoratti Jun 5, 2026

Choose a reason for hiding this comment

Uh oh!

akeren Jun 5, 2026

Choose a reason for hiding this comment

Uh oh!

vmoratti Jun 5, 2026

Choose a reason for hiding this comment

Uh oh!

akeren commented Jun 5, 2026

Uh oh!

github-actions Bot commented Jun 5, 2026

Uh oh!

github-actions Bot commented Jun 5, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

netlify Bot commented Jun 1, 2026 •

edited

Loading