fix: replace stale chrome-devtools refs in tests and scripts#1967
Closed
triuzzi wants to merge 6 commits intoChromeDevTools:mainfrom
Closed
fix: replace stale chrome-devtools refs in tests and scripts#1967triuzzi wants to merge 6 commits intoChromeDevTools:mainfrom
triuzzi wants to merge 6 commits intoChromeDevTools:mainfrom
Conversation
Co-Authored-By: Giancarlo Sorrentino <57813140+SirGian99@users.noreply.github.com>
* docs: rebrand CLI guide for Brave * 0.2.1
Updates remaining chrome-devtools references missed during the Brave
port to point at the renamed brave-devtools binaries and env vars,
and refreshes the third-party notices snapshot after recent dep bumps.
- tests/utils.ts: CLI_PATH points to build/src/bin/brave-devtools.js
- tests/check-for-updates.test.ts: BRAVE_DEVTOOLS_MCP_NO_UPDATE_CHECKS
- tests/tools/{screencast,pagesNavigateAllowlist}.test.ts:
import ParsedArguments from brave-devtools-mcp-cli-options
- scripts/{generate-docs,generate-cli,eval_gemini}.ts: spawn
build/src/bin/brave-devtools-mcp.js
- tests/third_party_notices.test.js.snapshot: regenerated
Co-Authored-By: Claude <noreply@anthropic.com>
Author
|
Wrong repo — closing. |
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Cleans up stale
chrome-devtoolsreferences that were missed during the Brave port and were causing test failures.tests/utils.ts:CLI_PATHnow points at the actualbuild/src/bin/brave-devtools.jsbinarytests/check-for-updates.test.ts: env var renamed fromCHROME_DEVTOOLS_MCP_NO_UPDATE_CHECKStoBRAVE_DEVTOOLS_MCP_NO_UPDATE_CHECKSto match the implementationtests/tools/{screencast,pagesNavigateAllowlist}.test.ts: type-onlyParsedArgumentsimport points atbrave-devtools-mcp-cli-options.js(came in via the upstream sync but kept the chrome path)scripts/{generate-docs,generate-cli,eval_gemini}.ts: spawnbuild/src/bin/brave-devtools-mcp.jsinstead of the chrome binary so dev/eval tooling actually starts the servertests/third_party_notices.test.js.snapshot: regenerated after recent upstream dependency bumpsTest plan
npm run typecheckpassesnpm run buildpassesnpm testpasses — full suite green on a Mac with Brave Browser installed (after clearing stale/tmp/brave-devtools-mcp-*state from previous runs)