Skip to content

UI: Clarify indexer seed time and client torrent preservation settings for My Anonamouse #129

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jberlyn wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

UI: Clarify indexer seed time and client torrent preservation settings for My Anonamouse #129

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/NzbDrone.Core/Download/Clients/rTorrent/RTorrent.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -143,7 +143,7 @@ protected override string AddFromTorrentFile(RemoteBook remoteBook, string hash,

public override string Name => "rTorrent";

public override ProviderMessage Message => new ProviderMessage($"rTorrent will not pause torrents when they meet the seed criteria. Chaptarr can remove torrents after seeding is done only when Remove Completed is enabled and the torrent is not protected by Keep seeding permanently or Post-Import Category. After importing it will also set \"{_imported_view}\" as an rTorrent view, which can be used in rTorrent scripts to customize behavior.", ProviderMessageType.Info);
public override ProviderMessage Message => new ProviderMessage($"rTorrent will not pause torrents when they meet the seed criteria. Chaptarr can remove torrents after seeding is done only when Remove Completed is enabled and the torrent is not protected by Preserve torrents in client or Post-Import Category. After importing it will also set \"{_imported_view}\" as an rTorrent view, which can be used in rTorrent scripts to customize behavior.", ProviderMessageType.Info);

public override IEnumerable<DownloadClientItem> GetItems()
{
Expand Down
2 changes: 1 addition & 1 deletion src/NzbDrone.Core/Download/DownloadImportModeResolver.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -126,7 +126,7 @@ private string GetPreserveReason(DownloadClientItem downloadClientItem)
// Tier 1: per-indexer protection for downloads Chaptarr grabbed.
if (grab?.IndexerId > 0 && ShouldNeverMoveForIndexer(grab.IndexerId))
{
return $"the indexer is configured to keep seeding permanently (IndexerId={grab.IndexerId})";
return $"the indexer is configured to preserve torrents in client (IndexerId={grab.IndexerId})";
}

// Tier 2: per-download-client protection for unmanaged downloads (no grab history).
Expand Down
2 changes: 1 addition & 1 deletion src/NzbDrone.Core/Indexers/MyAnonaMouse/MyAnonaMouseSettings.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -73,7 +73,7 @@ public int UseFreeleechWedge
[FieldDefinition(6, Type = FieldType.Checkbox, Label = "Integrate with Audiobookshelf", HelpText = "If you've connected ABS this will enhance your MAM searching", Hidden = HiddenType.Hidden)]
public bool IntegrateWithAbs { get; set; }

[FieldDefinition(7, Type = FieldType.Number, Label = "Seed Time", Unit = "hours", HelpText = "Number of hours to seed after download completes. MAM requires 72 hours within 30 days; values below 72 hours will warn.")]
[FieldDefinition(7, Type = FieldType.Number, Label = "Seed Time", Unit = "hours", HelpText = "Time in hours to seed before the download client stops the torrent. Leave empty to use the download client's default seeding rules. MAM requires at least 72 hours within 30 days; values below 72 hours will warn.")]
public int? SeedTimeHours { get; set; }

[FieldDefinition(8, Type = FieldType.Number, Label = "Early Download Limit", Unit = "days", HelpText = "Time before release date Chaptarr will download from this indexer, empty is no limit", Advanced = true)]
Expand Down
10 changes: 5 additions & 5 deletions src/NzbDrone.Core/Localization/Core/en.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -426,10 +426,10 @@
"ConversionTags": "Conversion Tags",
"ConvertedWaitingToImport": "Converted - Waiting to import",
"ConvertMp3ToM4b": "Convert MP3 to M4B",
"ConvertMp3ToM4bHelpText": "Before importing, convert downloaded MP3 files to M4B format. Original torrent files follow the same cleanup rules as other downloads: preserve them with Keep seeding permanently or Post-Import Category, otherwise remove them after seeding when Remove Completed Downloads is enabled.",
"ConvertMp3ToM4bHelpText": "Before importing, convert downloaded MP3 files to M4B format. Original torrent files follow the same cleanup rules as other downloads: preserve them with Preserve torrents in client or Post-Import Category, otherwise remove them after seeding when Remove Completed Downloads is enabled.",
"ConvertToFormat": "Convert To Format",
"ConvertToQuality": "Convert To",
"ConvertToQualityHelpText": "After download, convert compatible files to this format before importing. Original torrent files follow normal cleanup unless protected by Keep seeding permanently on the grabbing indexer or Post-Import Category on the download client. If neither applies, Chaptarr deletes the original torrent files after seeding is done and Remove Completed Downloads is enabled.",
"ConvertToQualityHelpText": "After download, convert compatible files to this format before importing. Original torrent files follow normal cleanup unless protected by Preserve torrents in client on the grabbing indexer or Post-Import Category on the download client. If neither applies, Chaptarr deletes the original torrent files after seeding is done and Remove Completed Downloads is enabled.",
"CopyToClipboard": "Copy to clipboard",
"CopyUnmanagedDownloads": "Copy unmanaged downloads",
"CopyUnmanagedDownloadsHelpText": "When Chaptarr did not grab a download (no grab history), import by copy/hardlink and never remove it from the download client.",
Expand Down Expand Up @@ -954,8 +954,8 @@
"IndexerSearchCheckNoAvailableIndexersMessage": "All search-capable indexers are temporarily unavailable due to recent indexer errors",
"IndexerSearchCheckNoInteractiveMessage": "No indexers available with Interactive Search enabled, Chaptarr will not provide any interactive search results",
"IndexerSettings": "Indexer Settings",
"IndexerSettingsNeverMoveOnImport": "Keep seeding permanently",
"IndexerSettingsNeverMoveOnImportHelpText": "For this indexer, always keep grabbed torrents and their files. Typically used for trackers with economy.",
"IndexerSettingsNeverMoveOnImport": "Preserve torrents in client",
"IndexerSettingsNeverMoveOnImportHelpText": "Always copy/hardlink files on import and never remove completed torrents or files from the download client for this indexer. (Does not override client seeding time/ratio limits).",
"IndexerSettingsSeedRatio": "Seed Ratio",
"IndexerSettingsSeedRatioHelpText": "The ratio a torrent should reach before stopping, empty uses the download client's default. Ratio should be at least 1.0 and follow the indexers rules",
"IndexerSettingsSeedTime": "Seed Time",
Expand Down Expand Up @@ -1632,7 +1632,7 @@
"Remove": "Remove",
"RemoveCompleted": "Remove Completed",
"RemoveCompletedDownloads": "Remove Completed Downloads",
"RemoveCompletedDownloadsHelpText": "Delete imported downloads from the download client when the client says they are safe to remove. For torrents, this usually means seeding has finished. This does not apply to torrents protected by Post-Import Category or Keep seeding permanently.",
"RemoveCompletedDownloadsHelpText": "Delete imported downloads from the download client when the client says they are safe to remove. For torrents, this usually means seeding has finished. This does not apply to torrents protected by Post-Import Category or Preserve torrents in client.",
"RemoveDownloadsAlert": "The Remove settings were moved to the individual Download Client settings in the table above.",
"RemoveFailed": "Remove Failed",
"RemoveFailedDownloads": "Remove Failed Downloads",
Expand Down
Loading